-
Notifications
You must be signed in to change notification settings - Fork 1.2k
feat: implement subagent fullscreen panel functionality #953
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Please help review this new submission. Thank you! |
|
Related issue: vadimdemedes/ink#809. Save it here to keep track. |
May I ask if this PR meets your expectations? I merely added a new display method, so it has nothing to do with ink#809 from the upstream. May I ask if it is acceptable? And as you can see from the screen recording, this method has no screen flickering at all, and it can achieve two-way data binding and free up and down scrolling. |
Need time to understand this issue properly. According to the attached issue, Claude Code is also heavily bothered by this issue. We just want to make sure we are doing the right thing. In my opinion, it is better to make it right than fast. |
|
The video looks promising though, will look it through, just need some time. We are very resource tight lately. |
I understand. Thank you. I look forward to your next move. Thanks. |
|
@x22x22 This feature looks cool, though we need to refine some details.
|



TLDR
Dive Deeper
核心改动
fullscreenContentuseMemo 与updateSubagentFullscreenPanel,保持实时同步。ctrl+alt+e提示,紧凑模式末尾也显示提示。content渲染,移除r刷新逻辑。ctrl+alt+e。updateSubagentFullscreenPanel,并在UIState持有当前面板状态。isInputActive仅在面板关闭时才允许输入。其他
TaskPromptSection兼容 compact 模式(无提示),default/verbose 模式显示提示。Reviewer Test Plan
Testing Matrix
Linked issues / bugs
实现效果
PS: 因为GitHub上传的视频有大小限制,所以视频加速了3倍播放,并做了压缩处理,所以很不清晰。
202511040318_20251104_03273193.mp4