Skip to content

chore: remove @qwik.dev/router dependency and fix bug when running start in ui folder #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
May 19, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
d699552
feat(ui): implement draggable devtools toggle button
JerryWu1234 Apr 12, 2025
0075f3a
add change
JerryWu1234 Apr 12, 2025
09ba2f0
fix bug
JerryWu1234 Apr 12, 2025
9520473
chore: update dependencies to Qwik v2.0.0-alpha.9 and Vite v6.2.6, en…
JerryWu1234 Apr 16, 2025
ee98786
chore: update vite-plugin-inspect to v11.0.0, adjust vite-hot-client …
JerryWu1234 Apr 16, 2025
c9e4290
Delete .changeset/flat-parrots-swim.md
JerryWu1234 Apr 17, 2025
2a2ae45
add change
JerryWu1234 Apr 17, 2025
793a15d
feat(inspect): add inspect feature to devtools
JerryWu1234 Apr 24, 2025
6ffb825
Merge branch 'QwikDev:main' into main-D
JerryWu1234 Apr 24, 2025
78c307c
Merge branch 'QwikDev:main' into main-D
JerryWu1234 Apr 25, 2025
900ade1
refactor(build): replace unbuild with tsdown for build configuration
JerryWu1234 Apr 25, 2025
f8e4778
style(ui): adjust layout and spacing in multiple components
JerryWu1234 May 15, 2025
500b5b7
Merge pull request #1 from QwikDev/main
JerryWu1234 May 15, 2025
8db4660
Merge branch 'main-D' of https://github.com/JerryWu1234/devtools into…
JerryWu1234 May 15, 2025
befca77
chore: remove space
gioboa May 15, 2025
7298343
chore: remove console.log
gioboa May 15, 2025
d0d3393
refactor(ui): remove @qwik.dev/router dependency and update component…
JerryWu1234 May 19, 2025
456bc70
Merge branch 'main-D' of https://github.com/JerryWu1234/devtools into…
JerryWu1234 May 19, 2025
961bef7
refactor(plugin): remove unused middleware in qwikDevtools function
JerryWu1234 May 19, 2025
2adfbb7
Merge remote-tracking branch 'origin/main' into main-D
JerryWu1234 May 19, 2025
cb2d42c
chore: remove unused import
gioboa May 19, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions packages/ui/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,7 @@
"qwik": "qwik"
},
"peerDependencies": {
"@qwik.dev/core": "^2.0.0-alpha.9",
"@qwik.dev/router": "^2.0.0-alpha.9"
"@qwik.dev/core": "^2.0.0-alpha.9"
},
"devDependencies": {
"@devtools/kit": "workspace:*",
Expand Down
9 changes: 6 additions & 3 deletions packages/ui/src/devtools.tsx
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
import {
component$,
useStore,
useVisibleTask$,
noSerialize,
useStyles$,
useSignal
useSignal,
useTask$,
isBrowser
} from "@qwik.dev/core";
import { tryCreateHotContext } from "vite-hot-client";
import {
Expand Down Expand Up @@ -57,7 +58,8 @@ export const QwikDevtools = component$(() => {
});

// eslint-disable-next-line qwik/no-use-visible-task
useVisibleTask$(async ({ track }) => {
useTask$(async ({ track }) => {
if (isBrowser) {
const hot = await tryCreateHotContext(undefined, ["/"]);

if (!hot) {
Expand Down Expand Up @@ -102,6 +104,7 @@ export const QwikDevtools = component$(() => {
});
}
});
}
});

return (
Expand Down
6 changes: 2 additions & 4 deletions packages/ui/src/features/Routes/Routes.tsx
Original file line number Diff line number Diff line change
@@ -1,13 +1,11 @@
import { component$ } from "@qwik.dev/core";
import { State } from "../../types/state";
import { useLocation } from "@qwik.dev/router";

interface RoutesProps {
state: State;
}

export const Routes = component$(({ state }: RoutesProps) => {
const location = useLocation();

return (
<div class="overflow-hidden rounded-xl border border-white/10 flex-1">
Expand All @@ -33,9 +31,9 @@ export const Routes = component$(({ state }: RoutesProps) => {
<span
class={{
"text-emerald-400":
(location.url.pathname === "/" &&
(location.pathname === "/" &&
route.relativePath === "") ||
location.url.pathname === `/${route.relativePath}/`,
location.pathname === `/${route.relativePath}/`,
}}
>
{route.relativePath === "" ? "/" : `/${route.relativePath}/`}
Expand Down
5 changes: 1 addition & 4 deletions packages/ui/src/features/inspect/Inspect.tsx
Original file line number Diff line number Diff line change
@@ -1,18 +1,15 @@
import { component$ } from "@qwik.dev/core";
// import { State } from "../../types/state";
import { useLocation } from "@qwik.dev/router";
import {inspectorLink} from './constant'
// interface RoutesProps {
// state: State;
// }

//@ts-ignore
export const Inspect = component$(() => {
const location = useLocation();
console.log(location);
return (
<div class="overflow-hidden rounded-xl border border-white/10 flex-1">
<iframe src={`${location.url.href}${inspectorLink}`} width={'100%'} height={'100%'}></iframe>
<iframe src={`${location.href}${inspectorLink}`} width={'100%'} height={'100%'}></iframe>
</div>
);
});
3 changes: 0 additions & 3 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.