Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🐞] v2 - Computed signal read in prop breaks component #7405

Closed
thejackshelton opened this issue Mar 9, 2025 · 0 comments · Fixed by #7410
Closed

[🐞] v2 - Computed signal read in prop breaks component #7405

thejackshelton opened this issue Mar 9, 2025 · 0 comments · Fixed by #7410
Assignees

Comments

@thejackshelton
Copy link
Member

Which component is affected?

Qwik Runtime

Describe the bug

There is an issue with useComputed$ where in dev mode it works, in production it breaks and affects other components in the app

isolating the issue:

  1. It works in production again after removing this piece of code in checkbox-trigger:
    aria-describedby={
        describedByLabels ? describedByLabels.value : undefined
    }

describedByLabels is a computed

		const describedByLabels = useComputed$(() => {
			const labels = [];
			if (context.description) {
				labels.push(descriptionId);
			}
			if (context.isErrorSig.value) {
				labels.push(errorId);
			}
			return labels.join(" ") || undefined;
		});

Reproduction

https://github.com/thejackshelton/v2-repro-computed/tree/main

Steps to reproduce

Reproduction steps:

  1. pnpm i && pnpm preview
  2. notice that the checkbox does not check or toggle, and there is an error from qwik core in the console

working behavior:

  1. run dev mode
  2. notice that it is toggling in dev mode

System Info

System:
    OS: macOS 15.1
    CPU: (16) arm64 Apple M4 Max
    Memory: 2.26 GB / 48.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 20.12.2 - /usr/local/bin/node
    Yarn: 1.22.22 - /usr/local/bin/yarn
    npm: 10.5.0 - /usr/local/bin/npm
    pnpm: 9.5.0 - /usr/local/bin/pnpm
    bun: 1.1.7 - ~/.bun/bin/bun
  Browsers:
    Safari: 18.1
  npmPackages:
    typescript: 5.4.5 => 5.4.5 
    undici: * => 7.4.0 
    vite: 5.3.5 => 5.3.5

Additional Information

No response

@thejackshelton thejackshelton added STATUS-1: needs triage New issue which needs to be triaged TYPE: bug Something isn't working labels Mar 9, 2025
@Varixo Varixo added COMP: runtime VERSION: upcoming major and removed STATUS-1: needs triage New issue which needs to be triaged labels Mar 10, 2025
@Varixo Varixo self-assigned this Mar 10, 2025
@Varixo Varixo linked a pull request Mar 10, 2025 that will close this issue
@Varixo Varixo closed this as completed Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants