Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: finding vnodes on interaction #7410

Merged
merged 1 commit into from
Mar 10, 2025
Merged

fix: finding vnodes on interaction #7410

merged 1 commit into from
Mar 10, 2025

Conversation

Varixo
Copy link
Member

@Varixo Varixo commented Mar 10, 2025

We should always call the toLowerCase fn on node names, because they are always uppercased

@Varixo Varixo self-assigned this Mar 10, 2025
@Varixo Varixo requested a review from a team as a code owner March 10, 2025 20:22
Copy link

changeset-bot bot commented Mar 10, 2025

🦋 Changeset detected

Latest commit: 289cc06

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@qwik.dev/core Patch
eslint-plugin-qwik Patch
@qwik.dev/react Patch
@qwik.dev/router Patch
create-qwik Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

pkg-pr-new bot commented Mar 10, 2025

Open in Stackblitz

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/core@7410
npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/router@7410
npm i https://pkg.pr.new/QwikDev/qwik/eslint-plugin-qwik@7410
npm i https://pkg.pr.new/QwikDev/qwik/create-qwik@7410

commit: 289cc06

Copy link
Contributor

github-actions bot commented Mar 10, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview 289cc06

@Varixo Varixo merged commit e7433d2 into build/v2 Mar 10, 2025
19 checks passed
@Varixo Varixo deleted the v2-finding-vnodes branch March 10, 2025 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
1 participant