Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Caution advised - Package.json docs.dev Windows support #7177

Closed

Conversation

Shane-Donlon
Copy link
Contributor

What is it?

  • Bug

Description

See issue 7175
This has only been tested in Windows

There may be a few Pull Requests about this topic.
I will keep issue 7175 up to date, but I need to test all the commands etc...

This resolves issue 1 & issue 4(also see comments of issue 7175 for localhost confirmation)

Issue 1:

112.3 error: failed to compile `wasm-pack v0.13.1`, intermediate artifacts can be found at `/tmp/cargo-install2iOZDd`.
112.3 To reuse those artifacts with a future compilation, set the environment variable `CARGO_TARGET_DIR` to that path.
112.3
112.3 Caused by:
112.3   package `clap_derive v4.5.18` cannot be built because it requires rustc 1.74 or newer, while the currently active rustc version is 1.73.0

Issue 4:
the && with CD is not compatible with windows, migrated to concurrently.
This has only been tested in windows.

> [email protected] docs.dev {location of stuff}\qwik
> cd packages/docs && pnpm build.repl-sw && pnpm dev

cd: no such file or directory: packages/docs

Note a changeset didn't seem appropriate for this PR, as the options were only files I had not changed,

PS any feedback, please feel free to pass it along!

Checklist

  • My code follows the developer guidelines of this project
  • I performed a self-review of my own code
  • I added a changeset with pnpm change
  • I made corresponding changes to the Qwik docs
  • I added new tests to cover the fix / functionality

Copy link

changeset-bot bot commented Dec 18, 2024

⚠️ No Changeset found

Latest commit: 590b202

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

pkg-pr-new bot commented Dec 18, 2024

Open in Stackblitz

npm i https://pkg.pr.new/@builder.io/qwik@7177
npm i https://pkg.pr.new/@builder.io/qwik-city@7177
npm i https://pkg.pr.new/eslint-plugin-qwik@7177
npm i https://pkg.pr.new/create-qwik@7177

commit: 590b202

Copy link
Contributor

github-actions bot commented Dec 18, 2024

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview 590b202

@gioboa
Copy link
Member

gioboa commented Dec 18, 2024

I can test it on Linux Ubuntu and MacOS

@wmertens
Copy link
Member

Hmm actually we use

$ rustc --version
rustc 1.83.0-nightly (fb4aebddd 2024-09-30)

I don't understand how 0.74 non-nightly can work, we use unstable features which are only available in nightly

See the file rust-toolchain

@Shane-Donlon
Copy link
Contributor Author

Hey Wout,

Update from the rust-toolchain file.

nightly-2024-10-01

I did revert the rust-toolchain file to nightly-2024-07-01 and the Dockerfile to FROM cimg/rust:1.73-node and that combination allows me to build.

It seems that

  • nightly-2024-10-01 && rust1.73 build failed
  • nightly-2024-07-01 && rust1.73 build succeeded
  • nightly-2024-10-01 && rust1.74 build succeeded

@Shane-Donlon
Copy link
Contributor Author

Hey everyone,
So I realised I had ran the incorrect command.

But I do have an update.

nightly-2024-07-01 & FROM cimg/rust:1.73-node produced the below error for me.

Command executed:

devcontainer up --workspace-folder .
471.4 error: failed to compile `wasm-pack v0.13.1`, intermediate artifacts can be found at `/tmp/cargo-installTRXqCz`.
471.4 To reuse those artifacts with a future compilation, set the environment variable `CARGO_TARGET_DIR` to that path.
471.4
471.4 Caused by:
471.4   package `clap_lex v0.7.2` cannot be built because it requires rustc 1.74 or newer, while the currently active rustc version is 1.73.0
------

nightly-2024-07-01 & FROM cimg/rust:1.74-node

  • Successfully built the docker container.

nightly-2024-10-01 & FROM cimg/rust:1.74-node

  • Successfully built the docker container.

nightly-2024-10-01 & FROM cimg/rust:1.73-node

  • Did not build.
  • package clap_derive v4.5.18 cannot be built error

nightly-2024-07-01 & FROM cimg/rust:1.73-node

  • Did not build.
  • package clap_lex v0.7.2 cannot be built error

@wmertens
Copy link
Member

Can't you use a more recent rust?

@Shane-Donlon
Copy link
Contributor Author

Absolutely, I was trying to explain why I requested a version bump in my PR from 1.73 to 1.74 in the Dockerfile.

Issue 7175 is to explain some of the challenges and errors, I faced going through the instructions.
This request is to try and resolve some of the errors.

The version of Rust I have installed locally is from the link in the contributing document.

installed toolchains
--------------------

stable-x86_64-pc-windows-msvc (default)
nightly-2024-07-01-x86_64-pc-windows-msvc
nightly-2024-10-01-x86_64-pc-windows-msvc

active toolchain
----------------

stable-x86_64-pc-windows-msvc (default)
rustc 1.83.0 (90b35a623 2024-11-26)

@Shane-Donlon
Copy link
Contributor Author

Hey Gio, Wout, Irfan,
Closing this as a duplication of effort.

Sorry to be dragging everyone in, I know Github sends a lot of emails 😢

But I did just wanted to take a moment to align on this.
Wout appears to be taking the lead on this with @iitzIrFan in PR #7201

@ everyone

But for now - I am going to take a step away from this.
Have a great day everyone.

Thanks,
Shane

@gioboa
Copy link
Member

gioboa commented Dec 29, 2024

Thanks for your help @Shane-Donlon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants