-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Caution advised - Package.json docs.dev Windows support #7177
Conversation
|
commit: |
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
I can test it on Linux Ubuntu and MacOS |
Hmm actually we use $ rustc --version I don't understand how 0.74 non-nightly can work, we use unstable features which are only available in nightly See the file |
Hey Wout, Update from the
I did revert the It seems that
|
Hey everyone, But I do have an update.
Command executed:
|
Can't you use a more recent rust? |
Absolutely, I was trying to explain why I requested a version bump in my PR from 1.73 to 1.74 in the Dockerfile. Issue 7175 is to explain some of the challenges and errors, I faced going through the instructions. The version of Rust I have installed locally is from the link in the contributing document.
|
Hey Gio, Wout, Irfan, Sorry to be dragging everyone in, I know Github sends a lot of emails 😢 But I did just wanted to take a moment to align on this. @ everyone
But for now - I am going to take a step away from this. Thanks, |
Thanks for your help @Shane-Donlon |
What is it?
Description
See issue 7175
This has only been tested in Windows
There may be a few Pull Requests about this topic.
I will keep issue 7175 up to date, but I need to test all the commands etc...
This resolves issue 1 & issue 4(also see comments of issue 7175 for localhost confirmation)
Issue 1:
Issue 4:
the && with CD is not compatible with windows, migrated to concurrently.
This has only been tested in windows.
Note a changeset didn't seem appropriate for this PR, as the options were only files I had not changed,
PS any feedback, please feel free to pass it along!
Checklist
pnpm change