Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: textarea with null value #7196

Merged
merged 2 commits into from
Dec 27, 2024
Merged

fix: textarea with null value #7196

merged 2 commits into from
Dec 27, 2024

Conversation

Varixo
Copy link
Member

@Varixo Varixo commented Dec 26, 2024

No description provided.

@Varixo Varixo self-assigned this Dec 26, 2024
@Varixo Varixo requested a review from a team as a code owner December 26, 2024 09:57
Copy link

changeset-bot bot commented Dec 26, 2024

🦋 Changeset detected

Latest commit: ef92d10

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@qwik.dev/core Patch
eslint-plugin-qwik Patch
@qwik.dev/react Patch
@qwik.dev/router Patch
create-qwik Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

pkg-pr-new bot commented Dec 26, 2024

Open in Stackblitz

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/core@7196
npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/router@7196
npm i https://pkg.pr.new/QwikDev/qwik/eslint-plugin-qwik@7196
npm i https://pkg.pr.new/QwikDev/qwik/create-qwik@7196

commit: ef92d10

Copy link
Contributor

github-actions bot commented Dec 26, 2024

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview ef92d10

Copy link
Member

@wmertens wmertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Just a suggestion for the name of the variable other than that good to merge

packages/qwik/src/core/shared/utils/jsx-filename.ts Outdated Show resolved Hide resolved
@Varixo Varixo force-pushed the v2-textarea-null-value branch from 9b144bf to ef92d10 Compare December 27, 2024 12:34
@Varixo Varixo merged commit c029c32 into build/v2 Dec 27, 2024
19 checks passed
@Varixo Varixo deleted the v2-textarea-null-value branch December 27, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants