fix: the useOn hook not working with Slot

[JerryWu1234]

What is it?

fixes #7230

fix: modify jsx output when it is Slot.
example :

</Slot>

<>
  <script>
  </Slot>
<>

Description

Checklist

• My code follows the developer guidelines of this project
• I performed a self-review of my own code
• I added a changeset with pnpm change
• I made corresponding changes to the Qwik docs
• I added new tests to cover the fix / functionality

[changeset-bot]

🦋 Changeset detected

Latest commit: 4793ed0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages

Name	Type
@qwik.dev/core	Patch
eslint-plugin-qwik	Patch
@qwik.dev/react	Patch
@qwik.dev/router	Patch
create-qwik	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[pkg-pr-new]

Open in Stackblitz

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/core@7250

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/router@7250

npm i https://pkg.pr.new/QwikDev/qwik/eslint-plugin-qwik@7250

npm i https://pkg.pr.new/QwikDev/qwik/create-qwik@7250

commit: 4793ed0

[github-actions]

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name	Status	Preview	Last Commit
qwik-docs	✅ Ready (View Log)	Visit Preview	4793ed0

[Varixo]

Hey, thank you for your contribution, but this is not a good solution. We can't add special condition for every edge case in the vnode-diff.

Tip: the problem is somewhere in this function

qwik/packages/qwik/src/core/shared/component-execution.ts

Line 133 in ad4444c

function addUseOnEvents(

[JerryWu1234]

Hey, thank you for your contribution, but this is not a good solution. We can't add special conditionl for every edge case in the vnode-diff.

Tip: the problem is somewhere in this function

qwik/packages/qwik/src/core/shared/component-execution.ts

Line 133 in ad4444c

function addUseOnEvents(

There are a couple of problems. Q: template also has a problem with usedocument. However I will find a better way to do it. And will tell you when I finish it

[Varixo]

Hey, thank you for your contribution, but this is not a good solution. We can't add special conditionl for every edge case in the vnode-diff.
Tip: the problem is somewhere in this function

qwik/packages/qwik/src/core/shared/component-execution.ts

Line 133 in ad4444c

function addUseOnEvents(

There are a couple of problems. Q: template also has a problem with usedocument. However I will find a better way to do it. And will tell you when I finish it

I think we need to just modify jsx output to be:

<>
  <script ... />
  <Slot />
</>

instead of just <Slot />

[Varixo]

if you need more help with that let me know

[Varixo]

Good job! I have added some comments

[Varixo]

Awesome work! Nice job! 😃
I added some comments

[wmertens]

Looks great I just wonder about that maybeThen

[Varixo]

LGTM!

[devcaeg]

Hello!

Sorry for being nosy, but the return <Slot /> error not only affected “useOn” but also the “useTask$”, “useTaskVisible$”, was it taken into account in this PR?