Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Windows Docs.dev script #7388

Merged
merged 5 commits into from
Mar 3, 2025
Merged

Conversation

Shane-Donlon
Copy link
Contributor

What is it?

  • Bug

Description

Hey everyone,
Unfortunately the below PR did not fully fix the issue on Windows.

#7301

There were 2 underlying issues.

  1. the cd to packages/docs in the root package.json did not work. packages/docs the "/" did not work on windows.
    -> moved to pnpm -c

  2. in file: check-qwik-build.ts the dirname variable on windows began with a "/" (forward slash)
    This would cause the check to fail on Windows as the directory was incorrect -> this has been resolved

  3. revert the dev script in packages/docs package.json
    The use of concurrently is no longer needed for Windows support as this has been resolved in step 2 above.

This has been tested on the below Operating Systems:
System:
OS: Windows 11 10.0.26100
OS: Linux 6.8 Linux Mint 22.1 (Xia)

Checklist

  • [x ] My code follows the developer guidelines of this project
  • [x ] I performed a self-review of my own code
  • I added a changeset with pnpm change (no changes needed?)
  • I made corresponding changes to the Qwik docs (no changes needed)
  • [x ] I added new tests to cover the fix / functionality

When running tests locally on windows the below has failed

PR incoming at some point on the tests
It'll likely be next weekend (but confirm that you want an issue logged for it)

FAIL packages/qwik/src/cli/add/update-files.unit.ts > mergeIntegrationDir > should merge integration directory in a monorepo
AssertionError: expected [ …(5) ] to deeply equal [ …(5) ]

  • Expected
  • Received

    Array [

  • "destDir/subDestDir/apps/subpackage/fake.ts",
  • "destDir/subDestDir/should-stay-in-root.ts",
  • "destDir/subDestDir/package.json",
  • "destDir/subDestDir/should-stay/should-also-stay.ts",
  • "destDir/subDestDir/apps/subpackage/src/global.css",
  • "destDir\subDestDir\apps\subpackage\fake.ts",
  • "destDir\subDestDir\should-stay-in-root.ts",
  • "destDir\subDestDir\package.json",
  • "destDir\subDestDir\should-stay\should-also-stay.ts",
  • "destDir\subDestDir\apps\subpackage\r\src\global.css",
    ]

FAIL packages/qwik/src/cli/add/update-files.unit.ts > mergeIntegrationDir > should merge integration directory
AssertionError: expected [ 'destDir\subDestDir\fake.ts', …(2) ] to deeply equal [ 'destDir/subDestDir/fake.ts', …(2) ]

  • Expected
  • Received

    Array [

  • "destDir/subDestDir/fake.ts",
  • "destDir/subDestDir/package.json",
  • "destDir/subDestDir/src/global.css",
  • "destDir\subDestDir\fake.ts",
  • "destDir\subDestDir\package.json",
  • "destDir\subDestDir\r\src\global.css",
    ]

FAIL packages/eslint-plugin-qwik/qwik.unit.ts [ packages/eslint-plugin-qwik/qwik.unit.ts ]
Error: ENOENT: no such file or directory, scandir 'C:\C:{lcoation of stuff}\qwik\packages\eslint-plugin-qwik\tests'
console.log results
testDir C:\Users{location of stuff}\qwik\packages\eslint-plugin-qwik\tests
this now works on windows.

Test results before:

Test Files  3 failed (3)
      Tests  3 failed | 24 passed (27)
   Duration  10ms

Test results after:

 Test Files  2 failed | 1 passed (3)
      Tests  3 failed | 61 passed (64)
   Duration  2.98s

Sorry, something went wrong.

Copy link

changeset-bot bot commented Mar 2, 2025

⚠️ No Changeset found

Latest commit: d6b66d9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

pkg-pr-new bot commented Mar 2, 2025

Open in Stackblitz

npm i https://pkg.pr.new/@builder.io/qwik@7388
npm i https://pkg.pr.new/@builder.io/qwik-city@7388
npm i https://pkg.pr.new/eslint-plugin-qwik@7388
npm i https://pkg.pr.new/create-qwik@7388

commit: d6b66d9

Copy link
Contributor

github-actions bot commented Mar 2, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview d6b66d9

@Shane-Donlon Shane-Donlon marked this pull request as ready for review March 2, 2025 18:09
@Shane-Donlon Shane-Donlon requested review from a team as code owners March 2, 2025 18:09
@Shane-Donlon
Copy link
Contributor Author

Fixes #7175

@Varixo Varixo merged commit c51aaab into QwikDev:main Mar 3, 2025
19 checks passed
@Varixo
Copy link
Member

Varixo commented Mar 3, 2025

Thank you for your work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants