Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description
Hey everyone,
Unfortunately the below PR did not fully fix the issue on Windows.
#7301
There were 2 underlying issues.
the cd to packages/docs in the root package.json did not work. packages/docs the "/" did not work on windows.
-> moved to pnpm -c
in file: check-qwik-build.ts the dirname variable on windows began with a "/" (forward slash)
This would cause the check to fail on Windows as the directory was incorrect -> this has been resolved
revert the dev script in packages/docs package.json
The use of concurrently is no longer needed for Windows support as this has been resolved in step 2 above.
This has been tested on the below Operating Systems:
System:
OS: Windows 11 10.0.26100
OS: Linux 6.8 Linux Mint 22.1 (Xia)
Checklist
pnpm change
(no changes needed?)When running tests locally on windows the below has failed
PR incoming at some point on the tests
It'll likely be next weekend (but confirm that you want an issue logged for it)
FAIL packages/qwik/src/cli/add/update-files.unit.ts > mergeIntegrationDir > should merge integration directory in a monorepo
AssertionError: expected [ …(5) ] to deeply equal [ …(5) ]
Received
Array [
]
FAIL packages/qwik/src/cli/add/update-files.unit.ts > mergeIntegrationDir > should merge integration directory
AssertionError: expected [ 'destDir\subDestDir\fake.ts', …(2) ] to deeply equal [ 'destDir/subDestDir/fake.ts', …(2) ]
Received
Array [
]
FAIL packages/eslint-plugin-qwik/qwik.unit.ts [ packages/eslint-plugin-qwik/qwik.unit.ts ]
Error: ENOENT: no such file or directory, scandir 'C:\C:{lcoation of stuff}\qwik\packages\eslint-plugin-qwik\tests'
console.log results
testDir C:\Users{location of stuff}\qwik\packages\eslint-plugin-qwik\tests
this now works on windows.
Test results before:
Test results after: