-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: don't wrap template literals with a function call inside in a si… #7390
Conversation
🦋 Changeset detectedLatest commit: abc7732 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Overview
This PR fixes an issue where template literals inside signals are incorrectly wrapped with a function call. Key changes include:
- Adding a new test case (should_not_wrap_var_template_string) to ensure template literals are not wrapped.
- Updating the transform logic to bypass wrapping for both function call and template literal expressions.
- Updating the changeset file to document the bug fix.
Reviewed Changes
File | Description |
---|---|
packages/qwik/src/optimizer/core/src/test.rs | Adds a test to verify that template literals are not wrapped. |
packages/qwik/src/optimizer/core/src/transform.rs | Updates logic to bypass wrapping for template literals. |
.changeset/chilly-fans-shave.md | Documents the patch release with updated messaging. |
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
f7ff000
to
dd9730b
Compare
dd9730b
to
abc7732
Compare
commit: |
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
I think this breaks #6585 again |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No description provided.