Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refactor vSiblings #7401

Merged
merged 2 commits into from
Mar 14, 2025
Merged

chore: refactor vSiblings #7401

merged 2 commits into from
Mar 14, 2025

Conversation

Varixo
Copy link
Member

@Varixo Varixo commented Mar 7, 2025

Remove vSiblings logic, they are no longer needed. Replace them with a Map for keyed nodes and with an array for non-keyed nodes to speed up diffing

@Varixo Varixo self-assigned this Mar 7, 2025
@Varixo Varixo requested a review from a team as a code owner March 7, 2025 21:24
Copy link

changeset-bot bot commented Mar 7, 2025

⚠️ No Changeset found

Latest commit: 8da2884

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Varixo Varixo force-pushed the v2-remove-v-siblings branch from 0b9ff37 to 54ecdb3 Compare March 7, 2025 21:27
Copy link

pkg-pr-new bot commented Mar 7, 2025

Open in Stackblitz

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/core@7401
npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/router@7401
npm i https://pkg.pr.new/QwikDev/qwik/eslint-plugin-qwik@7401
npm i https://pkg.pr.new/QwikDev/qwik/create-qwik@7401

commit: 8da2884

Copy link
Contributor

github-actions bot commented Mar 7, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview 8da2884

@Varixo Varixo marked this pull request as draft March 7, 2025 21:45
@Varixo Varixo force-pushed the v2-remove-v-siblings branch from 2867654 to 8da2884 Compare March 13, 2025 18:15
@Varixo Varixo marked this pull request as ready for review March 13, 2025 18:19
@Varixo Varixo changed the title chore: remove vSiblings chore: refactor vSiblings Mar 13, 2025
Copy link
Member

@wmertens wmertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@wmertens wmertens merged commit 6dd8a97 into build/v2 Mar 14, 2025
19 checks passed
@wmertens wmertens deleted the v2-remove-v-siblings branch March 14, 2025 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants