Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: toMatchDOM fix and refactor #7427

Merged
merged 1 commit into from
Mar 15, 2025
Merged

Conversation

Varixo
Copy link
Member

@Varixo Varixo commented Mar 15, 2025

toMatchDOM matcher did not work correctly for comparing attributes. Refactored all matcher code and replaced it with string comparison done by vitest. Now the messages are nicer.

@Varixo Varixo self-assigned this Mar 15, 2025
@Varixo Varixo requested a review from a team as a code owner March 15, 2025 09:49
Copy link

changeset-bot bot commented Mar 15, 2025

⚠️ No Changeset found

Latest commit: 55734a6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Varixo Varixo force-pushed the v2-to-match-dom-refactor branch from f0c9d42 to 55734a6 Compare March 15, 2025 12:28
@Varixo Varixo requested review from a team as code owners March 15, 2025 12:28
Copy link

pkg-pr-new bot commented Mar 15, 2025

Open in Stackblitz

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/core@7427
npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/router@7427
npm i https://pkg.pr.new/QwikDev/qwik/eslint-plugin-qwik@7427
npm i https://pkg.pr.new/QwikDev/qwik/create-qwik@7427

commit: 55734a6

Copy link
Contributor

github-actions bot commented Mar 15, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview 55734a6

Copy link
Member

@wmertens wmertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes much nicer!

@wmertens wmertens merged commit a8f0942 into build/v2 Mar 15, 2025
19 checks passed
@wmertens wmertens deleted the v2-to-match-dom-refactor branch March 15, 2025 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants