Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(starters): styled vanilla extract update devDependncies #7429

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Shane-Donlon
Copy link
Contributor

What is it?

  • Feature / enhancement
  • Bug

Description

@wmertens

Hey Wout
Sorry for the tag, but I think this is your integration, so would appreciate your input here.

Small update:

seems @vanilla-extract/vite-plugin was missing from the devDependencies which would cause error when starting dev server: Error [ERR_MODULE_NOT_FOUND]: Cannot find package '@vanilla-extract/vite-plugin'

I did link the CLI globally and just updating the devDependencies seems to have fixed the issue with the /styled-flower/ route without any adjustments.

I'll leave it as a draft for now, let me know what you think.

  • [ x] My code follows the developer guidelines of this project
  • [ x] I performed a self-review of my own code
  • I added a changeset with pnpm change
  • I made corresponding changes to the Qwik docs

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Copy link

changeset-bot bot commented Mar 15, 2025

⚠️ No Changeset found

Latest commit: 895c53d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

pkg-pr-new bot commented Mar 15, 2025

Open in Stackblitz

npm i https://pkg.pr.new/@builder.io/qwik@7429
npm i https://pkg.pr.new/@builder.io/qwik-city@7429
npm i https://pkg.pr.new/eslint-plugin-qwik@7429
npm i https://pkg.pr.new/create-qwik@7429

commit: 895c53d

Copy link
Contributor

github-actions bot commented Mar 15, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview 895c53d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant