fix: removing text node from shared text node #7430
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After ssr it, we get ie. "0123" as one text node, then we materialize 4 fragements with one letter in each.
We should get:
but this also means that every vnode right after materializing will point to the same shared textnode "0123". Of course we need to split it to separate text nodes, and this should be done at time of removing. In this case we did it to late, when virtual parent didn't have connections to siblings.