Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change client side generated ID to start with build base #7432

Merged
merged 1 commit into from
Mar 18, 2025

Conversation

Varixo
Copy link
Member

@Varixo Varixo commented Mar 16, 2025

Use build base for client side generated ID and convert first char to letter if it is statring from number, because CSS selectors can't start with number

@Varixo Varixo self-assigned this Mar 16, 2025
@Varixo Varixo requested a review from a team as a code owner March 16, 2025 18:26
Copy link

changeset-bot bot commented Mar 16, 2025

🦋 Changeset detected

Latest commit: 6ef1f49

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@qwik.dev/core Patch
eslint-plugin-qwik Patch
@qwik.dev/react Patch
@qwik.dev/router Patch
create-qwik Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

pkg-pr-new bot commented Mar 16, 2025

Open in Stackblitz

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/core@7432
npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/router@7432
npm i https://pkg.pr.new/QwikDev/qwik/eslint-plugin-qwik@7432
npm i https://pkg.pr.new/QwikDev/qwik/create-qwik@7432

commit: 1d54b16

Copy link
Contributor

github-actions bot commented Mar 16, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview 6ef1f49

@Varixo Varixo force-pushed the v2-refactor-use-id branch from 6ef1f49 to 1d54b16 Compare March 18, 2025 18:47
Copy link
Member

@wmertens wmertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌞

@wmertens wmertens enabled auto-merge March 18, 2025 18:52
@wmertens wmertens merged commit f640012 into build/v2 Mar 18, 2025
17 checks passed
@wmertens wmertens deleted the v2-refactor-use-id branch March 18, 2025 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[🐞] v2 Targeting id inside style tag or useStylesScoped$ not working on client side
2 participants