Skip to content

fix: serialize less vnode data #7636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 26, 2025
Merged

fix: serialize less vnode data #7636

merged 3 commits into from
May 26, 2025

Conversation

Varixo
Copy link
Member

@Varixo Varixo commented May 23, 2025

Improve vNode data serialization, simplify the SsrNode class, remove unnecessary vnode preparation logic

@Varixo Varixo self-assigned this May 23, 2025
@Varixo Varixo requested a review from a team as a code owner May 23, 2025 18:56
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented May 23, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: c1baa6c

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Varixo Varixo mentioned this pull request May 23, 2025
Closed
@Varixo Varixo moved this from Backlog to Waiting For Review in Qwik Development May 23, 2025
@Varixo Varixo marked this pull request as draft May 23, 2025 18:56
@Varixo Varixo force-pushed the v2-serialize-vnode-data-change branch from 536cf58 to c474a8b Compare May 23, 2025 19:03
@Varixo Varixo linked an issue May 23, 2025 that may be closed by this pull request
[v2] .map is too eager in creating qrls #7572
Closed
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented May 23, 2025 •
edited
Loading

Open in StackBlitz

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/core@7636

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/router@7636

npm i https://pkg.pr.new/QwikDev/qwik/eslint-plugin-qwik@7636

npm i https://pkg.pr.new/QwikDev/qwik/create-qwik@7636

commit: c1baa6c

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 23, 2025 •
edited
Loading

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview c1baa6c

@Varixo Varixo force-pushed the v2-serialize-vnode-data-change branch from bea4474 to a417ba7 Compare May 24, 2025 08:52
@Varixo Varixo force-pushed the v2-serialize-vnode-data-change branch from a417ba7 to c1baa6c Compare May 24, 2025 08:56
@Varixo Varixo marked this pull request as ready for review May 26, 2025 16:50
@Varixo Varixo requested a review from a team as a code owner May 26, 2025 16:50
wmertens
wmertens approved these changes May 26, 2025
View reviewed changes
Copy link
Member

@wmertens wmertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wmertens wmertens merged commit e2eb140 into build/v2 May 26, 2025
19 checks passed
@wmertens wmertens deleted the v2-serialize-vnode-data-change branch May 26, 2025 16:58
@github-project-automation github-project-automation bot moved this from Waiting For Review to Done in Qwik Development May 26, 2025
@github-actions github-actions bot mentioned this pull request May 26, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wmertens wmertens wmertens approved these changes

Assignees

@Varixo Varixo

Labels
VERSION: upcoming major
Projects
Qwik Development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[v2] .map is too eager in creating qrls
2 participants
@Varixo @wmertens