Skip to content

fix: ssg on windows #8072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
+18 −7
Draft

fix: ssg on windows #8072

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d8cab78
fix: ssg build windows error
Varixo Oct 18, 2025
e696be1
chore: reenable windows e2e tests on CI
Varixo Oct 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -682,6 +682,8 @@ jobs:
# too slow and flaky. Perhaps better in v2?
# - host: ubuntu-latest
# browser: firefox
- host: windows-latest
browser: chromium
- host: macos-latest
browser: webkit
# - host: windows-latest
Expand Down
23 changes: 16 additions & 7 deletions packages/qwik-city/src/static/node/node-main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import type {
import fs from 'node:fs';
import { cpus as nodeCpus } from 'node:os';
import { Worker } from 'node:worker_threads';
import { isAbsolute, resolve } from 'node:path';
import { dirname, extname, isAbsolute, join, resolve } from 'node:path';
import { ensureDir } from './node-system';
import { normalizePath } from '../../utils/fs';
import { createSingleThreadWorker } from '../worker-thread';
Expand Down Expand Up @@ -78,14 +78,23 @@ export async function createNodeMainProcess(sys: System, opts: StaticGenerateOpt

let workerFilePath: string | URL;

// Launch the worker using the package's index module, which bootstraps the worker thread.
if (typeof __filename === 'string') {
workerFilePath = __filename;
// CommonJS path
const ext = extname(__filename) || '.js';
workerFilePath = join(dirname(__filename), `index${ext}`);
} else {
workerFilePath = import.meta.url;
}
// ESM path (import.meta.url)
const thisUrl = new URL(import.meta.url);
const pathname = thisUrl.pathname || '';
let ext = '.js';
if (pathname.endsWith('.ts')) {
ext = '.ts';
} else if (pathname.endsWith('.mjs')) {
ext = '.mjs';
}

if (typeof workerFilePath === 'string' && workerFilePath.startsWith('file://')) {
workerFilePath = new URL(workerFilePath);
workerFilePath = new URL(`./index${ext}`, thisUrl);
}

const nodeWorker = new Worker(workerFilePath, { workerData: opts });
Expand Down Expand Up @@ -146,7 +155,7 @@ export async function createNodeMainProcess(sys: System, opts: StaticGenerateOpt
});

nodeWorker.on('exit', (code) => {
if (code !== 1) {
if (code !== 0) {
console.error(`worker exit ${code}`);
}
});
Expand Down