Various fixes to calc_CentralDose() and snapshot tests #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We deprecate the `na.rm` argument as allowing the user to set it to FALSE would lead to unusable results (all NAs) or buggy behaviour.
If sigma converges to zero we stop the fixed-point interation early, as otherwise a zero sigma value would cause divisions by zero and produce infinities, which would eventually lead to this error message: Error in sig/delta : non-numeric argument to binary operator thrown when computing if(!log) sig <- sig / delta as sig is of class "try-error", as it is computed as: sig <- try(seq(sig0, sig1, sig1 / 1000), silent = TRUE) where sig1 is Inf.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #302 as discussed in #302 (comment):
na.rmargument, removing missing values by defaultIt also stops the fixed-point early iteration if sigma converges to zero, so that we don't produce avoidable infinities.
This also adds some snapshot tests (part of #243).