Improve fitting of the BTS model in fit_IsothermalHolding() #561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This tests 1000 random values for the s parameter instead of optimizing it, as that was found to be practically the only way to get this model to fit.
This is at the moment not exposed, but it's already very helpful to make the analyse_Thermochronometry test for the BTS model run in a reasonable time (a few seconds rather than several minutes).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default this tests 1000 random values for the
sparameter instead of optimizing it, as @RLumSK found it to be practically the only way to get this model to fit.For tests to run in a reasonable time I've added a "hidden" argument
num_s_values_btsto be able to change the default from 1000 values to something much smaller. We could expose that later.