Optimize subsetting #220
Open
Optimize subsetting #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to avoid overlapping issues
… in replacement string
…set expressions fix(brackets.lua): ensure only first level of subsetting for $ operator is processed refactor(brackets.lua): simplify replacement logic in formatsubsetting function
…gs for clarity refactor(brackets.lua): separate processing of extract_operator and subset nodes into distinct passes for better maintainability and readability
style(brackets.lua): remove redundant comment about empty table style(brackets.lua): simplify comments on applying replacements in reverse order
refactor(brackets.lua): streamline build_extract_operator_replacement function fix(brackets.lua): ensure correct replacement of extract_operator nodes perf(brackets.lua): optimize replacement application order
… for the $ operator
|
It's falling in this case: aa$bb$$cc |
|
This also doesn't seem to be 100% correct: aa <- list(bb=c("w" = 1, "x" = 2, "y"= 3, "z" = 4))
aa$bb[3]because the output of |
|
Good catch. Will work on that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a complete rework of this functionality. It avoids using recursive function, which simplify the logic. It is also faster.