Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix R3BRoot/r3bbase/R3BFileSource2.h:29:48: error: no template named … #939

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

audreychatillon
Copy link
Contributor

…'optional' in namespace 'std'

fix error: invalid use of incomplete type ‘class std::basic_ostream’

Describe your proposal.

Mention any issue this PR is resolved or is related to.


Checklist:

…'optional' in namespace 'std'

fix error: invalid use of incomplete type ‘class std::basic_ostream<char>’
@YanzhaoW
Copy link
Contributor

Thanks a lot for the PR. This problem comes from my PR #910 and I had no idea why it compiled successfully both in the CI and lxir136 machine.

But I did see it when I tried to compile R3BRoot using gcc12.

Which gcc version do you use when you found this issue?

Also please create another PR based on dev branch and as it's a small change, we could merge it quickly as well. @jose-luis-rs

@audreychatillon
Copy link
Contributor Author

gcc --version
gcc (Ubuntu 11.4.0-1ubuntu1~22.04) 11.4.0

@YanzhaoW
Copy link
Contributor

Yeah, that makes sense. In our CI, gcc version is 8.3.0 and probably gcc 8 includes some headers by default and somehow they are not included anymore in newer versions.

@jose-luis-rs jose-luis-rs merged commit a6e40e8 into R3BRootGroup:202402_fast Jan 19, 2024
3 checks passed
@audreychatillon audreychatillon deleted the fixcomp_fast branch January 19, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants