Implemented an endpoint to handle file uploads #117
Conversation
| # The name of the S3 bucket where files will be uploaded. | ||
| # bucketName: radar | ||
| # Path-related settings for organizing stored files. | ||
| path: |
There was a problem hiding this comment.
I wondered if we should utilise functionality from radar-output's path factory (it would be good to harmonise across components). We can likely extract that bit of functionality from radar output to the radar-commons library and re-use in both components. Let's discuss in the next meeting
There was a problem hiding this comment.
And this can be tackled in a separate issue and PR
There was a problem hiding this comment.
Let's discuss in the next meeting
Okay
radar-gateway/src/main/kotlin/org/radarbase/gateway/config/S3StorageConfig.kt
Outdated
Show resolved
Hide resolved
|
|
||
| data class StorageConditionConfig ( | ||
| val fileUploadEnabled: Boolean = true, | ||
| val radarStorageType: String = "s3" |
There was a problem hiding this comment.
The radar output's target-based system can also inspire this. Again, we can extract common functionality and reuse it here. That would allow supporting multiple target systems without extra effort.
There was a problem hiding this comment.
Sure, I will proceed after understanding the output repository in the next meeting.
radar-gateway/src/main/kotlin/org/radarbase/gateway/resource/FileUploadResource.kt
Outdated
Show resolved
Hide resolved
radar-gateway/src/main/kotlin/org/radarbase/gateway/service/storage/MinioClientLoaderImpl.kt
Outdated
Show resolved
Hide resolved
radar-gateway/src/main/kotlin/org/radarbase/gateway/service/storage/path/StoragePath.kt
Outdated
Show resolved
Hide resolved
radar-gateway/src/main/kotlin/org/radarbase/gateway/utils/Paths.kt
Outdated
Show resolved
Hide resolved
this-Aditya
force-pushed
the
file-storage
branch
from
1944b6e to
e72feca
Compare
Screenshot of MinIO tested locally: