Support latest EKS versions #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baixiac
reviewed
Dec 12, 2024
cluster/data.tf
Outdated
Comment on lines
13
to
32
| "1.31" : { | ||
| "cluster_version" = "1.31" | ||
| "cluster_addons" = { | ||
| "coredns" = "v1.10.1-eksbuild.10" | ||
| "kube_proxy" = "v1.28.1-eksbuild.1" | ||
| "vpc_cni" = "v1.16.4-eksbuild.2" | ||
| "ebs_csi_driver" = "v1.26.1-eksbuild.1" | ||
| "coredns" = "v1.11.3-eksbuild.2" | ||
| "kube_proxy" = "v1.30.6-eksbuild.3" | ||
| "vpc_cni" = "v1.19.0-eksbuild.1" | ||
| "ebs_csi_driver" = "v1.37.0-eksbuild.1" | ||
| } | ||
| }, | ||
| "1.27" : { | ||
| "cluster_version" = "1.27" | ||
| "1.29" : { | ||
| "cluster_version" = "1.31" | ||
| "cluster_addons" = { | ||
| "coredns" = "v1.10.1-eksbuild.7" | ||
| "kube_proxy" = "v1.27.10-eksbuild.2" | ||
| "vpc_cni" = "v1.15.3-eksbuild.1" | ||
| "ebs_csi_driver" = "v1.25.0-eksbuild.1" | ||
| "coredns" = "v1.11.3-eksbuild.2" | ||
| "kube_proxy" = "v1.29.10-eksbuild.3" | ||
| "vpc_cni" = "v1.19.0-eksbuild.1" | ||
| "ebs_csi_driver" = "v1.37.0-eksbuild.1" | ||
| } | ||
| }, | ||
| "1.26" : { | ||
| "cluster_version" = "1.26" | ||
| "1.28" : { | ||
| "cluster_version" = "1.31" |
There was a problem hiding this comment.
I can see the mismatch between keys and cluster_versions in the EKS version dict. Are they typos or intentional?
There was a problem hiding this comment.
They're fixed now.
| @@ -122,6 +122,8 @@ Created resources (if all enabled): | |||
|
|
|||
| Make sure to install [terraform-docs](https://github.com/terraform-docs/terraform-docs) and run `make prepare` before making a commit to make sure the documentation is up to date and the code is valid. | |||
|
|
|||
| In order to support new version of EKS you need to make sure the addons that we use are compatible with the new target version. You can get a list of addons and their EKS compatiblity with running `aws eks describe-addons-versions` and then searching for the addons that are defined in `cluster/data.tf`. | |||
|
|
|||
keyvaann
force-pushed
the
update-eks-version
branch
from
1bd8146 to
4514258
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for latest version of EKS and its addons. I did a test install for v1.31 and installation was successful. I assume v1.30 will work as wel.