Create EKS admins group #31
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baixiac
reviewed
Dec 12, 2024
There was a problem hiding this comment.
The maximum number of user groups a single user can belong to is hard-limited to 10 per region, which won't scale as the number of clusters grows. This limit hit us in the past so the idea of using the admin group was ditched in this commit. The other changes on README look good to me.
|
We can probably make this a configurable flag to either attach it to a group or a user. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now when creating an EKS cluster the access is given to the users individually, I think it's a better practice to create a group and add users to that group instead.
I updated the documentation, I hope it's not too vague.