Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gradle, Dependencies and workflows Updated #65

Merged
merged 4 commits into from
Mar 14, 2024
Merged

Gradle, Dependencies and workflows Updated #65

merged 4 commits into from
Mar 14, 2024

Conversation

this-Aditya
Copy link
Member

Fixes: #54

Hi @yatharthranjan, I haven't updated the radarCommonsVersion and radarJerseyVersion to the most recent release because some project structure changes are breaking the project.
I am also not sure about updating the confluentVersion and kafkaVersion. Please let me know if they need to be updated.

with:
java-version: 11
distribution: temurin
java-version: 17
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you also update the dockerfile

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure!

@yatharthranjan
Copy link
Member

I am also not sure about updating the confluentVersion and kafkaVersion. Please let me know if they need to be updated.

Yes those can be updated. You can find the compatibility matrix for those two here - https://docs.confluent.io/platform/current/installation/versions-interoperability.html

I haven't updated the radarCommonsVersion and radarJerseyVersion to the most recent release because some project structure changes are breaking the project.

ok -- I think those should be updated as well (and quite important as security is handled through radar-jersey). If you are having issues, please create a new issue so those can be handled too. @mpgxvii can you take a look if you have bandwidth?

@this-Aditya this-Aditya changed the title Build, Gradle and Dependencies Updated Gradle, Dependencies and workflows Updated Mar 8, 2024
Copy link
Member

@yatharthranjan yatharthranjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you.

@this-Aditya
Copy link
Member Author

Hi @yatharthranjan, also created a new issue for incompatible dependencies here.

@yatharthranjan yatharthranjan merged commit 1589292 into RADAR-base:dev Mar 14, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants