Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove cancelling of task notifications #1784

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Remove cancelling of task notifications #1784

wants to merge 2 commits into from

Conversation

mpgxvii
Copy link
Member

@mpgxvii mpgxvii commented Apr 15, 2024

@mpgxvii mpgxvii requested a review from yatharthranjan April 15, 2024 16:30
yatharthranjan
yatharthranjan reviewed Apr 16, 2024
View reviewed changes
Copy link
Member

@yatharthranjan yatharthranjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please find a comment below

src/app/core/services/schedule/schedule-factory.service.ts
@@ -75,6 +75,6 @@ export class ScheduleFactoryService extends ScheduleService {
}

updateTaskToComplete(updatedTask): Promise<any> {
return this.scheduleService.updateTaskToComplete(updatedTask)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be done for both types of scheduleservices. In local one the updateTaskToComplete function will also handle deleting of notifications for completed tasks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yatharthranjan yatharthranjan yatharthranjan left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mpgxvii @yatharthranjan