-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Sentry monitoring #387
Open
pvannierop
wants to merge
13
commits into
dev
Choose a base branch
from
feature/sentry
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To fix software vulnerability.
[Security] Fix software vulnerabilities for 0.8.11 release
Release 0.8.11
Try to fix CI error.
Improve version management and use of convention plugins for shared build logic.
Includes addition to documentation.
pvannierop
force-pushed
the
feature/sentry
branch
from
December 10, 2024 07:10
3a44173
to
2c4947d
Compare
ewelinagr
reviewed
Jan 21, 2025
@@ -14,3 +21,7 @@ dependencies { | |||
application { | |||
mainClass.set("org.radarbase.schema.service.SourceCatalogueServer") | |||
} | |||
|
|||
radarKotlin { | |||
sentryEnabled.set(true) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
javaVersion.set(Versions.java)
log4j2Version.set(Versions.log4j2)
not needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ewelinagr No, defaults are defined in the radar-commons kotlin project gradle plugin. Better to use these defaults.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: This PR will add option to monitor the application with Sentry. Sentry monitoring will be enabled by the following:
SENTRY_DSN
environment variable that points to the desired Sentry DSN.SENTRY_LOG_LEVEL
environment variable to control the minimum log level of events sent to Sentry.The default log level for Sentry is
ERROR
. Possible values areTRACE
,DEBUG
,INFO
,WARN
, andERROR
.The docs were updated with these instructions.
Important
This PR also changes the gradle config to the latest standards. Specifically, the version catalog and convention plugin features are implemented. The main reason for this is to remove the duplicated dependency versions in the project.