Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor improvements for audio plugin #466

Merged
merged 3 commits into from
Nov 11, 2024
Merged

Minor improvements for audio plugin #466

merged 3 commits into from
Nov 11, 2024

Conversation

this-Aditya
Copy link
Member

  • Corrected the Livedata behavior to stop observing after the manager stops instead of when the service stops.

@yatharthranjan
Copy link
Member

Hi, the schemas are released now. Can you please update to the latest version and ensure the CI jobs pass?
Thanks

@this-Aditya
Copy link
Member Author

Hi yatharth, I have already done that in this PR, while you were on vacation.

yatharthranjan
yatharthranjan approved these changes Nov 11, 2024
View reviewed changes
Copy link
Member

@yatharthranjan yatharthranjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yatharthranjan yatharthranjan merged commit 6347ede into dev Nov 11, 2024
3 checks passed
@yatharthranjan yatharthranjan deleted the audio-improve branch November 11, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yatharthranjan yatharthranjan yatharthranjan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@this-Aditya @yatharthranjan