-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added icon for google sleep plugin #134
base: dev
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Perhaps this would be a good generalization to add to the provider
fun imageResource(state: T?): Int
where each provider can implement their own image resource. For most devices that would be battery, but for others it can be just an icon.
Sure, thanks! I will update the Provider class soon. |
Is this superseded by #135 ? |
Hi, it doesn't. The supporting PR for #135 -> RADAR-base/radar-commons-android#437 was closed because it was not working for every plugin. |
Ok in that case, do we need to add more cases here for the other google plugins? |
As Joris suggested, it would be nice if generalized via radar-commons-android, and then each plugin can update its icon itself. Is it okay if I try to make it work in another PR again? |
ok, that would be great, thanks. |
Added new PR here -> #141. |
Updated the icon or google sleep plugin.