Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance improvement and simplification #44

Merged
merged 30 commits into from
Jan 19, 2025
Merged

Performance improvement and simplification #44

merged 30 commits into from
Jan 19, 2025

Conversation

RCasatta
Copy link
Owner

@RCasatta RCasatta commented Jan 18, 2025 •
edited
Loading

comparison with main branch

block_deserialize/slices                                                                            
                        time:   [108.27 µs 108.95 µs 109.84 µs]
                        thrpt:  [11.716 GiB/s 11.812 GiB/s 11.886 GiB/s]
                 change:
                        time:   [-33.777% -32.624% -31.584%] (p = 0.00 < 0.05)
                        thrpt:  [+46.164% +48.421% +51.006%]
                        Performance has improved.

RCasatta added 27 commits January 18, 2025 11:15
@RCasatta
Remove bytes number in error
5b1bdeb 
In the end the detail is misleading if propagated from a inner object,
thus better to get rid of it.
@RCasatta
Introduce scan_len fn
7f594a2
@RCasatta
add scan_len tests
e84e178
@RCasatta
add parse/scan len benches
3fa1a12
@RCasatta
add test block
f73fba4
@RCasatta
fix scan len
a2498e0
@RCasatta
add bench for script parsing
c00afd2
@RCasatta
improve script parsing by ~4%
8145db8
@RCasatta
add bench for witness
cec800a
@RCasatta
add test malformed witness
ed8e42b
@RCasatta
use scan_len and avoid read_slice in witness
8cdd0bc 
Notably the introduced bench for witness doesn't show change in
performance, but block_deserialize improve by 5% to 10% !!
@RCasatta
bench witnesses
82ddc1b 
by benching to parse multiple witness the performance increase with the
changes for witness become evident ~18%
@RCasatta
remove latest parse_len instance with scan_len
d92907e
@RCasatta
add simpler read numbers fn
765b89e
@RCasatta
add benches just for header
844df7a
@RCasatta
use new read fn for block_header
a929738
@RCasatta
avoid read_slice in OutPoint
603a287
@RCasatta
in Transaction avoid U* use read_u* fn
d3df677
@RCasatta
avoid U32,U64 in TxIn & TxOut
4c4b15c
@RCasatta
deprecate read_slice
6c3a319
@RCasatta
impl split_at_checked equivalent to respect MSRV
e5e8e93
@RCasatta
clippy lints
a631a95
@RCasatta
use 1.82.0 for clippy
2c7b27b
@RCasatta
fix possible overflow
da43447
@RCasatta
fix fuzz targets and run on nix
c896152
@RCasatta
add fuzz corpus
4edd90a
@RCasatta
add fuzz to ci
ae204e0
@RCasatta RCasatta merged commit d03e677 into main Jan 19, 2025
20 checks passed
@RCasatta RCasatta mentioned this pull request Jan 20, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@RCasatta