-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SPARQL endpoint opt in #257
Conversation
…fault. Add example responses / mediatypes to SPARQL get endpoint.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah looks good, thanks :)
Test suite updated to enable the sparql endpoint now that it is opt in. Also modified the sparql endpoint assertions as they were always true.
@recalcitrantsupplant I can't request your review as this is your PR but if you 'approve' the changes from my commit then I will approve the PR. |
thanks for the fix, I've changed it from "1" to "true" just for clarity |
@lalewis1 Can't see an option to approve your changes.. has it changed since I pushed another commit? |
Yeah im not sure how that works. i was hoping to 'suggest changes' but i needed to change a file that wasn't part of the PR so I had to push a new commit. anyway, im happy with it so I will approve. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all good thanks
Makes the SPARQL endpoint opt in using the enable_sparql_endpoint variable in settings; defaulted to False.