Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPARQL endpoint opt in #257

Merged
merged 3 commits into from
Aug 27, 2024
Merged

Conversation

recalcitrantsupplant
Copy link
Collaborator

Makes the SPARQL endpoint opt in using the enable_sparql_endpoint variable in settings; defaulted to False.

…fault.

Add example responses / mediatypes to SPARQL get endpoint.
lalewis1
lalewis1 previously approved these changes Aug 21, 2024
Copy link
Collaborator

@lalewis1 lalewis1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah looks good, thanks :)

@lalewis1 lalewis1 self-requested a review August 21, 2024 22:55
@lalewis1 lalewis1 dismissed their stale review August 21, 2024 22:56

didn't notice the tests were failling

Test suite updated to enable the sparql endpoint now that it is opt in.
Also modified the sparql endpoint assertions as they were always true.
@lalewis1
Copy link
Collaborator

@recalcitrantsupplant I can't request your review as this is your PR but if you 'approve' the changes from my commit then I will approve the PR.

@recalcitrantsupplant
Copy link
Collaborator Author

thanks for the fix, I've changed it from "1" to "true" just for clarity

@recalcitrantsupplant
Copy link
Collaborator Author

recalcitrantsupplant commented Aug 22, 2024

@lalewis1 Can't see an option to approve your changes.. has it changed since I pushed another commit?

@lalewis1
Copy link
Collaborator

Yeah im not sure how that works. i was hoping to 'suggest changes' but i needed to change a file that wasn't part of the PR so I had to push a new commit.

anyway, im happy with it so I will approve.

Copy link
Collaborator

@lalewis1 lalewis1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good thanks

@recalcitrantsupplant recalcitrantsupplant merged commit c5d3931 into main Aug 27, 2024
1 check passed
@recalcitrantsupplant recalcitrantsupplant deleted the david/make-sparql-endpoint-opt-in branch August 27, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants