-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Enhanced Targeting Features. #249
Conversation
I'll leave this PR open for comment for a couple of days, and I want to add the second half of the "targeting" feature-branch to this PR too. Then the combination of Focus Node select mode, and Shape select mode will allow powerful targeting that is otherwise not available in PySHACL. |
…x the python 3.8 compatible typing in the validator kwargs.
…e from the ShapesGraph.
…des in comparing results across runs.
…sGraph after implementing the better shape targeting feature.
The rest of the Enhanced Targeting features are landed in this PR. Focus Node Filtering, and Shape Selection
|
Looks good @ashleysommer. Perhaps we need to see the test suite results in GitHub though? I trust you have them all passing locally but as a PR reviewer, I would like to see them here too, rather than having to run them myself locally too to test. |
Yeah, I need to make a change in the PySHACL CI configuration, the Drone VM I used to have set up is no longer running. I'm not a fan of github-actions, but it seems like its the easiest way forward. |
Got whole test suite including linting, type-checking, and tox test matrix working in Github-actions, and merged the upstream changes into this PR, so you will now see the tests run against this PR. |
Update: See comment further down for big additional update to this PR.