Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for custom SSL/TLS certificates #147

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

syats
Copy link

@syats syats commented Mar 17, 2020

In order to handle SPARQL endpoints with self-signed certificates, a new parameter was introduced to the init of the Wrapper for a .pem file of the certificate.

@dayures
Copy link
Contributor

dayures commented Mar 22, 2020

@abuonomo @syats these two PR (#135 #147) are quite similar. From your experience, what could be the best and simplest solution?

@frankier
Copy link

I vote for this one (and otherwise generally approve this PR -- as far as that helps). The reason is that this way you can use certifi if you want.

e.g.

    import certifi
    from SPARQLWrapper import SPARQLWrapper

    sparql = SPARQLWrapper(endpoint, custom_cert_filename=certifi.where())

This is useful in case of outdated system certificates. Increasingly a problem to the extent that web browsers and the extremely popular Python library requests both bundle their own certificates (requests actually uses certifi).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants