Feature/integrate available reviews (#221)

* Adjust getAssignments * Remove print statements * Adjusting assignment status color and reviewer message * Use request_review_assignment parameter * Remove print statements
RENCI · Dec 9, 2022 · a7e947e · a7e947e
1 parent 03e1e4c
commit a7e947e
Show file tree

Hide file tree

Showing 5 changed files with 22 additions and 13 deletions.
diff --git a/client/src/modules/assignment/components/assignment-selection/refine-selection.js b/client/src/modules/assignment/components/assignment-selection/refine-selection.js
@@ -41,12 +41,12 @@ export const RefineSelection = ({ assignments, training = false }) => {
           <Assignments 
             type='refine' 
             header={ 'Under review' }
-            assignments={ assignments.filter(({ status, reviewer }) => status !== 'active' && reviewer?.login) }
+            assignments={ assignments.filter(({ status }) => status === 'review') }
           />
           <Assignments 
             type='refine' 
             header={ 'Awaiting review' }
-            assignments={ assignments.filter(({ status, reviewer }) => status === 'waiting' && !reviewer?.login) }
+            assignments={ assignments.filter(({ status }) => status === 'waiting') }
           />
         </Column>
         <Column>

diff --git a/client/src/modules/assignment/components/assignment-selection/review-selection.js b/client/src/modules/assignment/components/assignment-selection/review-selection.js
@@ -23,7 +23,7 @@ export const ReviewSelection = ({ review, waiting, volumes, training }) => {
       <Row>
         <Column>
           <Header as='h4'>
-            Your active { training && 'training' } reviews
+            Your { training && 'training' } reviews
             <Subheader>
               { reviewSubheader }
             </Subheader>

diff --git a/client/src/modules/assignment/components/assignments/assignment.js b/client/src/modules/assignment/components/assignments/assignment.js
@@ -21,7 +21,7 @@ export const Assignment = ({ assignment, enabled }) => {
   const onLoadClick = async () => {
     if (assignment.status === 'waiting') {
       try {
-        await api.requestAssignment(user._id, assignment.subvolumeId, assignment.id);
+        await api.requestAssignment(user._id, assignment.subvolumeId, assignment.id, true);
 
         const newAssignment = {
           ...assignment,
@@ -72,7 +72,7 @@ export const Assignment = ({ assignment, enabled }) => {
               <Label 
                 basic 
                 circular 
-                content='Reviewer' 
+                content={ assignment.status === 'review' ? 'Reviewer' : 'Latest reviewer' }
                 detail={ reviewer.login } 
               />
             </div>

diff --git a/client/src/utils/api.js b/client/src/utils/api.js
@@ -258,6 +258,7 @@ export const api = {
       return assignments;
     }, {})).filter(({ status }) => 
       getAll ? true : 
+      reviewer ? status === 'active' || status === 'under review' :
       status === 'awaiting review' || status === 'active' || status === 'under review'
     );
 
@@ -287,13 +288,17 @@ export const api = {
         const reviewResponse = await axios.get(`/item/${ id }/available_items_for_review`);
 
         for (const review of reviewResponse.data) {
-          // Check we don't already have it
-          if (!assignments.find(({ id }) => id === review.id)) {
-            availableReviews[n - 1].assignments.push({
-              id: review.id,
-              needToLoad: true
-            });
+          const index = assignments.findIndex(({ id }) => id === review.id);
+
+          if (index !== -1) {
+            console.warn(`Assignment ${ review.id } in reviewer assignments and available for review`);
+            assignments.splice(index, 1);
           }
+
+          availableReviews[n - 1].assignments.push({
+            id: review.id,
+            needToLoad: true
+          });          
         }
       }
     }
@@ -347,13 +352,14 @@ export const api = {
 
     return comments;
   },
-  requestAssignment: async (userId, subvolumeId, itemId) => {
+  requestAssignment: async (userId, subvolumeId, itemId, review = false) => {
     await axios.post(`/user/${ userId }/request_assignment`,
       null,
       {
         params: {
           subvolume_id: subvolumeId,
-          assign_item_id: itemId
+          assign_item_id: itemId,
+          request_review_assignment: review
         }
       }
     );

diff --git a/client/src/utils/assignment-utils.js b/client/src/utils/assignment-utils.js
@@ -29,11 +29,14 @@ export const statusDisplay = (status) => statusValues[status];
 export const statusOrder = (status) => statusValuesOrder[status];
 
 export const statusColor = (status, reviewer) => 
+  statusColors[status]
+/*
   // Need to check reviewer login because review status is not always set...
   status === 'active' || status === 'review' || status === 'completed' ? statusColors[status] :
   reviewer?.login ? statusColors['review'] :
   status === 'waiting' ? statusColors['waiting'] : 
   null;
+  */
 
 export const isActive = ({ status }) => status === 'active';