Allow sending RTR messages #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ItsHarper
reviewed
Sep 19, 2024
| @@ -178,6 +180,7 @@ class CANMessage { | |||
| uint8_t m_size; | |||
| uint32_t m_messageId; | |||
| uint32_t m_timestamp; | |||
| bool m_is_remote; | |||
There was a problem hiding this comment.
It looks like this doesn't actually get used, is that correct?
There was a problem hiding this comment.
I'd initially intended it to be held in this class, but that changed. I'll remove this.
ItsHarper
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use the mask
0x80000000, like WPILib for specifying RTR. Note that Candlelib uses0x40000000to mean RTR, so we have to translate.