Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plot style #18

Merged
merged 6 commits into from
Mar 7, 2024
Merged

Plot style #18

merged 6 commits into from
Mar 7, 2024

Conversation

trappitsch
Copy link
Contributor

Plot style can now in GUI be selected from a dropdown menu.
Possible options are:

  • light
  • dark
  • light transparent
  • dark transparent

The Plotter itself has an overwrite routine to ignore not only the dark mode that is set, but to also ignore the transparent mode.
If transparent is set, the style is selected when returning the figure with the fig property.

- drop down menu incorporated with "light", "dark", "light transparent", "dark transparent"
- Added plotter overwrite for transparent before returning the figure
Copy link

codecov bot commented Mar 7, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 93.80%. Comparing base (f94c282) to head (3dff529).

Files Patch % Lines
src/rimsschemedrawer/plotter.py 40.00% 3 Missing ⚠️
src/rimsschemedrawer/json_parser.py 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #18      +/-   ##
==========================================
+ Coverage   93.22%   93.80%   +0.58%     
==========================================
  Files           9        9              
  Lines         649      662      +13     
==========================================
+ Hits          605      621      +16     
+ Misses         44       41       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@trappitsch trappitsch merged commit 87a268f into main Mar 7, 2024
8 of 9 checks passed
@trappitsch trappitsch deleted the plot_mode_dropdown branch March 7, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant