Merge pull request #20577 from Teufelchen1/fix/eddystone

ble/skald: Always enforce URL length check
RIOT-OS · Apr 16, 2024 · d708f8d · d708f8d
2 parents 48838f4 + da79068
commit d708f8d
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/sys/net/ble/skald/skald_eddystone.c b/sys/net/ble/skald/skald_eddystone.c
@@ -96,7 +96,10 @@ void skald_eddystone_url_adv(skald_ctx_t *ctx,
 {
     assert(url && ctx);
     size_t len = strlen(url);
-    assert(len <= (NETDEV_BLE_PDU_MAXLEN - (URL_HDR_LEN + PREAMBLE_LEN)));
+    if (len <= (NETDEV_BLE_PDU_MAXLEN - (URL_HDR_LEN + PREAMBLE_LEN))) {
+        assert(0);
+        return;
+    }
 
     eddy_url_t *pdu = (eddy_url_t *)ctx->pkt.pdu;
     _init_pre(&pdu->pre, EDDYSTONE_URL, (URL_HDR_LEN + len));