sys/shell/ping: add protection from icmp packet overflow

RIOT-OS · Sep 16, 2023 · e0c4ebf · e0c4ebf
1 parent ee081d1
commit e0c4ebf
Showing 1 changed file with 8 additions and 1 deletion.
diff --git a/sys/shell/cmds/gnrc_icmpv6_echo.c b/sys/shell/cmds/gnrc_icmpv6_echo.c
@@ -172,6 +172,7 @@ static int _configure(int argc, char **argv, _ping_data_t *data)
 {
     char *cmdname = argv[0];
     int res = 1;
+    int value;
 
     /* parse command line arguments */
     for (int i = 1; i < argc; i++) {
@@ -207,7 +208,13 @@ static int _configure(int argc, char **argv, _ping_data_t *data)
                     /* intentionally falls through */
                 case 's':
                     if ((++i) < argc) {
-                        data->datalen = atoi(argv[i]);
+                        value = atoi(argv[i]);
+
+                        if(value < 0 || value > 65527) {
+                            printf("ICMPv6 datagram size should be in range <0, 65527>.\n");
+                            return -1;
+                        }
+                        data->datalen = value;
                         continue;
                     }
                     /* intentionally falls through */