Skip to content

Commit

Permalink
boards/nucleo-{f207zg,f746zg,f767zi}: periph_conf
Browse files Browse the repository at this point in the history
Fix PHY address in eth_config. It should be 0 for these boards, not 1. This is
why previously the link status read out worked with an hard code PHY address
0 before.

Some dubious references for 0 being the correct PHY address and not 1 (in
absence of proper references):

https://www.carminenoviello.com/2016/01/22/getting-started-stm32-nucleo-f746zg/
https://community.st.com/s/question/0D50X00009XkgfISAR/stm32f767-nucleo-ethernet-not-working
  • Loading branch information
Marian Buschsieweke committed Oct 12, 2020
1 parent a65b4e1 commit e9361ed
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion boards/nucleo-f207zg/include/periph_conf.h
Original file line number Diff line number Diff line change
Expand Up @@ -241,7 +241,7 @@ static const eth_conf_t eth_config = {
.speed = ETH_SPEED_100TX_FD,
.dma = 6,
.dma_chan = 8,
.phy_addr = 0x01,
.phy_addr = 0x00,
.pins = {
GPIO_PIN(PORT_G, 13),
GPIO_PIN(PORT_B, 13),
Expand Down
2 changes: 1 addition & 1 deletion boards/nucleo-f746zg/include/periph_conf.h
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,7 @@ static const eth_conf_t eth_config = {
.speed = ETH_SPEED_100TX_FD,
.dma = 7,
.dma_chan = 8,
.phy_addr = 0x01,
.phy_addr = 0x00,
.pins = {
GPIO_PIN(PORT_G, 13),
GPIO_PIN(PORT_B, 13),
Expand Down
2 changes: 1 addition & 1 deletion boards/nucleo-f767zi/include/periph_conf.h
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ static const eth_conf_t eth_config = {
.speed = ETH_SPEED_100TX_FD,
.dma = 3,
.dma_chan = 8,
.phy_addr = 0x01,
.phy_addr = 0x00,
.pins = {
GPIO_PIN(PORT_G, 13),
GPIO_PIN(PORT_B, 13),
Expand Down

0 comments on commit e9361ed

Please sign in to comment.