-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pkg/bme680 driver: add support for I2C/SPI BME680 driver #10502
Conversation
Signed-off-by: dylad <[email protected]>
… pkg Signed-off-by: dylad <[email protected]>
@dylad Thanks for your contribution. Before we start adding drivers as packages, we should discuss and find an agreement for some questions that came up with my PR #10363.
|
I have no strong opinion on it, maybe a dedicated sub-directory could be better ? But we will need to modify a bit the build system I guess. In any case, I propose to open an issue to regroup all the discussions in a specific place.
I think it's a good approach to unify drivers and package drivers, it will require some extra works but I think it's worthwhile. We must define how it will look like before.
For this point, my suggestion is to keep the API documentation from the original repo but we also must document any patches or adaptation level to RIOT in order to explain how it works. I'll create an issue to centralize discussions about package drivers. |
@@ -0,0 +1,44 @@ | |||
# U8g2 Package Test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Readme copied from U8g2 without updating contents to bme680
#define BME680_SPI_SPEED (SPI_CLK_1MHZ) | ||
#endif /* BME680_SPI_SPEED */ | ||
|
||
#ifndef BME6800_SPI_MODE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be:
#ifndef BME680_SPI_MODE
Sorry for the delayed answer, |
@dylad Are you still working on this? Some of my colleagues need a driver within RIOT. |
@roberthartung |
Close in favor of #12717 |
Contribution description
This PR adds support for I2C/SPI BME680 sensor as package.
In a previous PR, @aabadie proposes to support this driver as a package because its quite complicate and Bosch already provides a working driver on their repo [1].
This driver is labelled as WIP because I'm not fully happy and I need some advises/reviews to enhance it. Furthermore, I only tested the I2C part on a custom board. I'll need some help to test the SPI part before merging this PR.
Testing procedure
run the dedicated test application using
make -C tests/pkg_bme680_driver
You may need to modify some params to match your hardware. (Comments are very welcome here)
Issues/PRs references
#9909
[1] https://github.com/BoschSensortec/BME680_driver