Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cpu/mips32r2: remove nomips16 attribute from _mips_handle_exception [backport 2019.07] #12288

Merged
merged 1 commit into from
Sep 23, 2019
Merged

cpu/mips32r2: remove nomips16 attribute from _mips_handle_exception [backport 2019.07] #12288

merged 1 commit into from
Sep 23, 2019

Conversation

kaspar030
Copy link
Contributor

Backport of #11986

Contribution description

A note says "The nomips16 attribute should not really be needed,
it works around a toolchain issue in 2016.05-03."

In fact, in 2018.09-03, the attribute leads to this error:

cpu/mips32r2_common/thread_arch.c:191:1: error: ‘_mips_handle_exception’ redeclared with conflicting ‘nomips16’ attributes

This this commit removes the attribute.

Testing procedure

Successful build and basic test on any mips32r2 board should suffice.

Issues/PRs references

Needed for RIOT-OS/riotdocker#76

@kaspar030
cpu/mips32r2: remove nomips16 attribute from _mips_handle_exception
1f5a64e 
A note says "The nomips16 attribute should not really be needed,
it works around a toolchain issue in 2016.05-03."

In fact, in 2018.09-03, the attribute leads to this error:

```cpu/mips32r2_common/thread_arch.c:191:1: error: ‘_mips_handle_exception’ redeclared with conflicting ‘nomips16’ attributes```

This this commit removes the attribute.

(cherry picked from commit b415588)
@kaspar030 kaspar030 added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: MIPS Platform: This PR/issue effects MIPS-based platforms Process: release backport Integration Process: The PR is a release backport of a change previously provided to master Process: release cycle Integration Process: The PR is connected to the release cycle (e.g. release notes) Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation labels Sep 23, 2019
@kaspar030 kaspar030 requested a review from benpicco September 23, 2019 10:08
@kaspar030 kaspar030 mentioned this pull request Sep 23, 2019
Merged
@kaspar030
Copy link
Contributor Author

Wow, "backport_pr.py" is awesome! 👍

benpicco
benpicco approved these changes Sep 23, 2019
View reviewed changes
Copy link
Contributor

@benpicco benpicco left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The workaround for an old toolchain issue should only be applied with the old toolchain.
This is also valid for the stable release - no side effects are to be expected.

@benpicco benpicco merged commit 56f38a6 into RIOT-OS:2019.07-branch Sep 23, 2019
@kaspar030 kaspar030 deleted the backport/2019.07/mips_remove_nomips16 branch September 23, 2019 11:08
@kaspar030 kaspar030 mentioned this pull request Sep 26, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benpicco benpicco benpicco approved these changes

Assignees
No one assigned
Labels
CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: MIPS Platform: This PR/issue effects MIPS-based platforms Process: release backport Integration Process: The PR is a release backport of a change previously provided to master Process: release cycle Integration Process: The PR is connected to the release cycle (e.g. release notes) Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kaspar030 @benpicco