Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dist/tools/ci: print toolchain version update for esp8266 #13027

Merged

Conversation

gschorcht
Copy link
Contributor

Contribution description

The new ESP8266 port in PR #11108 uses a different tool chain than the previous implementation. The version check must be updated accordingly.

Testing procedure

Without this PR the output of command dist/tools/ci/print_toolchain_versions.sh should either show

   xtensa-lx106-elf-gcc: xtensa-lx106-elf-gcc (crosstool-NG crosstool-ng-1.22.0-60-g37b07f6) 4.8.5
xtensa-lx106-elf-newlib: "2.2.0"

or

   xtensa-lx106-elf-gcc: missing
xtensa-lx106-elf-newlib: missing

With this PR it should show:

   xtensa-esp8266-elf-gcc: xtensa-esp8266-elf-gcc (crosstool-NG crosstool-ng-1.22.0-80-g6c4433a5) 5.2.0
xtensa-esp8266-elf-newlib: "2.2.0"

Issues/PRs references

Needed because of PR #11108

The new ESP8266 port in PR RIOT-OS#11108 requires a different tool chain than the previous implementation. The version check must be updated accordingly.
@gschorcht gschorcht added Area: toolchain Area: toolchains; everything related to compilation, libc, linking, … Area: tools Area: Supplementary tools CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: ESP Platform: This PR/issue effects ESP-based platforms Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) labels Jan 4, 2020
@fjmolinas
Copy link
Contributor

Before install or if running in docker:

    xtensa-esp8266-elf-gcc: missing
    xtensa-esp8266-elf-newlib: missing

After install

    xtensa-esp8266-elf-gcc: xtensa-esp8266-elf-gcc (crosstool-NG crosstool-ng-1.22.0-80-g6c4433a5)    5.2.0
    xtensa-esp8266-elf-newlib: "2.2.0"

@fjmolinas
Copy link
Contributor

I took a quick look at discussion in #11808 and it seem at first you wanted to support both toolchain, but here you remove one of them. Did that change?

@gschorcht
Copy link
Contributor Author

I took a quick look at discussion in #11808 and it seem at first you wanted to support both toolchain, but here you remove one of them. Did that change?

The old toolchain is no longer needed with the current master. The CI tools should therefore check for the new toolchain and not for the old toolchain.

In the riotdocker image, both versions of the toolchain were simply necessary for the transition from the old ESP8266 port to the new ESP8266 port. But as soon as version 2020.01 is released, I will also remove the old toolchain from riotdocker.

@fjmolinas
Copy link
Contributor

@gschorcht perfect! Thanks for the clarification! ACK!

Copy link
Contributor

@fjmolinas fjmolinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK.

@fjmolinas fjmolinas merged commit 2729580 into RIOT-OS:master Jan 6, 2020
@gschorcht
Copy link
Contributor Author

@fjmolinas Thanks for reviewing, testing and merging it.

@gschorcht gschorcht deleted the dist/tools/esp8266_version_check branch January 7, 2020 00:15
@fjmolinas fjmolinas added this to the Release 2020.01 milestone Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: toolchain Area: toolchains; everything related to compilation, libc, linking, … Area: tools Area: Supplementary tools CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: ESP Platform: This PR/issue effects ESP-based platforms Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants