-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.github/workflows: add welcome bot #18618
Conversation
Testing "locally" on my repo doesn't seem to work out well. I currently am hitting actions/first-interaction#10 issue. Here are my test logs. The other thing that may be an issue is requiring maintainer approval to run this workflow. This kind of makes a welcome message to be patient a bit worthless. We can change the settings to run ALL workflows of first time contributors (unless they have a newly created account) without approval. It would be better to configure it to only run this one though. maybe ping @miri64 ? |
What of those things was I pinged for? |
General review. I feel you are the most knowledgeable GitHub actions person I know. If you are aware of a way we can test this then great, otherwise, does this make sense to merge in, as it is similar to the labeler workflow? |
IIRC it is easiest to test Github Actions in your own fork. You can provide links to the actions / PRs you tested upon. |
.github/workflows/welcome.yml
Outdated
repo-token: ${{ secrets.GITHUB_TOKEN }} | ||
issue-message: Beep boop beep... I am a real human... for real.\n\n | ||
Welcome to the RIOT community, we will try to address this as soon as we can. | ||
As I mentioned before, we are human and sometimes we get distracted with life. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I mentioned before, we are human and sometimes we get distracted with life. | |
As I mentioned before, we are human, many of us do this in our free time, and sometimes we get distracted with life. |
?
.github/workflows/welcome.yml
Outdated
pr-message: Beep boop beep... I am a real human... for real.\n\n | ||
Welcome to the RIOT community, we will try to review this as soon as we can. | ||
As I mentioned before, we are human and sometimes we get distracted with life. | ||
I can try to ping someone like this.\n\n | ||
ping @MrKevinWeiss\n\n | ||
Feel free to do the same for other [maintainers](https://github.com/orgs/RIOT-OS/teams/maintainers/members) if things are taking a while. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this is the same message as for issue-message
, could you try setting it as an environment variable and use it here and for issue-message
instead?
- uses: actions/first-interaction@v1
env:
GREETER_MESSAGE: >
Beep boop beep... I am a real human... for real.\n\n
Welcome to the RIOT community, we will try to address this as soon as we can.
As I mentioned before, we are human and sometimes we get distracted with life.
I can try to ping someone like this.\n\n
ping @MrKevinWeiss\n\n
Feel free to do the same for other [maintainers](https://github.com/orgs/RIOT-OS/teams/maintainers/members) if things are taking a while.
with:
repo-token: ${{ secrets.GITHUB_TOKEN }}
issue-message: ${{ env.GREETER_MESSAGE }}
pr-message: ${{ env.GREETER_MESSAGE }}
.github/workflows/welcome.yml
Outdated
Welcome to the RIOT community, we will try to address this as soon as we can. | ||
As I mentioned before, we are human and sometimes we get distracted with life. | ||
I can try to ping someone like this.\n\n | ||
ping @MrKevinWeiss\n\n |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You really want to use yourself as example? How about, e.g., @riot-ci instead?
Mh, just noticed: the action ran, so I am not sure what you were asking ^^ |
Thanks for taking a look, I will adapt!
The problem is that it never worked (as well as is very hard to test first time contributors as I need a new contributor per test). I thought maybe it is an issue of my personal repo settings or something. I will keep looking at it when I have time. |
Hmm OK, shall we or should I close, I am doing a general cleanup. |
afd5ff2
to
8ddbce9
Compare
Doesn't seem to work, so I am for closing... |
Good good. Wasn't so easy to test. |
Contribution description
To try to address #18563 I would like to add a welcome bot.
This should help give a bit more urgency to the first time contributors and show that is ok to ping people.
Testing procedure
Ya... turns out it is not too easy.
Issues/PRs references
Helps with #18563