tools/zep_dispatch: enhancements and fixes #19996
Conversation
benpicco
added
the
CI: ready for build
|
could you sketch a Testing procedure |
| @@ -13,6 +13,10 @@ | |||
| #include <math.h> | |||
| #include <unistd.h> | |||
|
|
|||
| #ifndef CONFIG_USE_NUMERIC_NAMES | |||
| #define CONFIG_USE_NUMERIC_NAMES 1 | |||
There was a problem hiding this comment.
why isn't that a comandline option
There was a problem hiding this comment.
Hm, I wasn't sure if I shouldn't remove it altogether.
The alphabetic names look nice for node numbers < 26, but once we use two letters, it's much more confusing than just numbering them.
| @@ -51,7 +72,7 @@ static double node_distance(const struct node *a, const struct node *b) | |||
|
|
|||
| static double node_distance_weight(const struct node *a, const struct node *b) | |||
| { | |||
| double w = 1 - node_distance(a, b) / a->r; | |||
| double w = 1 - pow(node_distance(a, b), 2) / pow(a->r, 2); | |||
There was a problem hiding this comment.
will this surprise people? (changing distance from linear to quadratic (more realistic))
There was a problem hiding this comment.
tbh I don't think there is currently anyone besides me using this
|
I would be interested at some point to discuss whether this tooling and des-virt can be merged somehow. It's a bit weird that we have (at least) two different network emulators in the repository - and apparently both them are used by only very few people. |
benpicco
force-pushed
the
topogen_enhance
branch
from
c47cff1 to
ba8130e
Compare
Contribution description
This is a collection of improvements I added while working on the CoAP multicast implementation.
topogen
dispatcher
Testing procedure
Issues/PRs references