Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net/gnrc/netif: set 6LN flag for ethernet if gnrc_sixloenc is used #20139

Merged
merged 1 commit into from
Dec 8, 2023

Conversation

benpicco
Copy link
Contributor

@benpicco benpicco commented Dec 4, 2023

Contribution description

AFAIU the gnrc_sixloenc enables 6lo encoding on ethernet.
This can be useful for very slow busses, where we want to reduce traffic as much as possible.

I noticed that GNRC would still perform duplicate address detection on startup - this was because the 6LN flag was not set yet.

Testing procedure

I enabled

USEMODULE += gnrc_sixloenc
CFLAGS += -DCONFIG_GNRC_IPV6_NIB_SLAAC=1
CFLAGS += -DCONFIG_GNRC_IPV6_NIB_NO_RTR_SOL=1
CFLAGS += -DCONFIG_GNRC_IPV6_NIB_ARSM=0

and now get serene silence on the bus if there is no traffic.

Issues/PRs references

@benpicco benpicco added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Area: network Area: Networking labels Dec 4, 2023
@github-actions github-actions bot added the Area: sys Area: System label Dec 4, 2023
@benpicco benpicco added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Dec 4, 2023
@riot-ci
Copy link

riot-ci commented Dec 5, 2023

Murdock results

✔️ PASSED

bc2c95c net/gnrc/netif: set 6LN flag for ethernet if gnrc_sixloenc is used

Success Failures Total Runtime
8082 0 8082 17m:43s

Artifacts

@benpicco benpicco requested a review from fabian18 December 6, 2023 21:00
Copy link
Contributor

@fabian18 fabian18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at places where gnrc_sixloenc is used it makes sense to add this change.

@benpicco benpicco added this pull request to the merge queue Dec 7, 2023
Merged via the queue into RIOT-OS:master with commit 81b5cf2 Dec 8, 2023
27 checks passed
@benpicco benpicco deleted the gnrc_sixloenc-fix branch December 8, 2023 11:23
@MrKevinWeiss MrKevinWeiss added this to the Release 2024.01 milestone Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: network Area: Networking Area: sys Area: System CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants