Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/flashdb: bump to 2.1.0 #20155

Merged
merged 1 commit into from
Dec 9, 2023

Conversation

OlegHahm
Copy link
Member

@OlegHahm OlegHahm commented Dec 5, 2023

Contribution description

Update to the latest version. Incorporate upstream patch by @fzi-haxel to prepare for 64bit platforms.

Testing procedure

The tests are still working:
pkg/flashdb_vfs
pkg/flashdb_mtd

@github-actions github-actions bot added the Area: pkg Area: External package ports label Dec 5, 2023
@benpicco benpicco added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Dec 6, 2023
pkg/flashdb/Makefile Outdated Show resolved Hide resolved
@OlegHahm OlegHahm force-pushed the pr/pkg/flashdb/versionbump branch from debc686 to a06eaab Compare December 6, 2023 17:11
@OlegHahm OlegHahm added the CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable label Dec 6, 2023
Copy link
Contributor

@benpicco benpicco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash

@riot-ci
Copy link

riot-ci commented Dec 6, 2023

Murdock results

✔️ PASSED

0e8b1c0 pkg/flashdb: bump to 2.1.0 + patches

Success Failures Total Runtime
8082 0 8082 09m:59s

Artifacts

@OlegHahm OlegHahm removed the CI: needs squashing Commits in this PR need to be squashed; If set, CI systems will mark this PR as unmergable label Dec 6, 2023
@OlegHahm OlegHahm force-pushed the pr/pkg/flashdb/versionbump branch from 9910d3a to 1c5e481 Compare December 6, 2023 21:00
@benpicco
Copy link
Contributor

benpicco commented Dec 8, 2023

You can directly squash trivial changes

@OlegHahm
Copy link
Member Author

OlegHahm commented Dec 8, 2023

I prefer to keep changes visible until being reviewed as described in our Contributing guidelines. Since you have apparently now acknowledged the change I will squash.

There are two more commits upstream after the 2.1.0 release which are
required to compile this package without warnings.
@OlegHahm OlegHahm force-pushed the pr/pkg/flashdb/versionbump branch from eb41a81 to 0e8b1c0 Compare December 8, 2023 20:36
@benpicco
Copy link
Contributor

benpicco commented Dec 8, 2023

The changes are still visible when you click the force-pushed link.

(Ok, that assumes the rebase is done only on the current branch so e.g. git rebase -i --autosquash HEAD~2 instead of git rebase -i --autosquash master)

@benpicco benpicco enabled auto-merge December 8, 2023 21:05
@OlegHahm
Copy link
Member Author

OlegHahm commented Dec 8, 2023

Thanks for pointing to this feature. Maybe we should update the Contributing guide accordingly?

@benpicco benpicco added this pull request to the merge queue Dec 8, 2023
@maribu maribu removed this pull request from the merge queue due to a manual request Dec 9, 2023
@maribu maribu added this pull request to the merge queue Dec 9, 2023
@maribu maribu removed this pull request from the merge queue due to a manual request Dec 9, 2023
@maribu maribu added this pull request to the merge queue Dec 9, 2023
Merged via the queue into RIOT-OS:master with commit 12fdab9 Dec 9, 2023
25 checks passed
@OlegHahm OlegHahm deleted the pr/pkg/flashdb/versionbump branch December 9, 2023 13:56
@MrKevinWeiss MrKevinWeiss added this to the Release 2024.01 milestone Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: pkg Area: External package ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants