Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests/periph/flashpage: make mtd_raw command write bytes instead of ASCII #20177

Merged
merged 1 commit into from
Jun 10, 2024
Merged

tests/periph/flashpage: make mtd_raw command write bytes instead of ASCII #20177

merged 1 commit into from
Jun 10, 2024

Conversation

fabian18
Copy link
Contributor

Contribution description

Given the name of the command write_raw in tests/periph/flashpage, it should accept raw bytes instead of a string.
This enables more possible test input.

Testing procedure

BOARD=same54-xpro make -C tests/periph/flashpage flash term

2023-12-13 12:52:07,847 # write_raw 0xFE000 11223344556677889
2023-12-13 12:52:07,852 # error: data must have an even length and must be <= 128
write_raw 0xFE000 112233445566778899
2023-12-13 12:52:14,145 # write_raw 0xFE000 112233445566778899
2023-12-13 12:52:14,150 # wrote local data to flash address 0xfe000 of len 9
read 127
2023-12-13 12:52:20,552 # read 127
2023-12-13 12:52:20,556 # Read flash page 127 into local page buffer
2023-12-13 12:52:20,557 # Local page buffer:
2023-12-13 12:52:20,566 # 00000000  11  22  33  44  55  66  77  88  99  FF  FF  FF  FF  FF  FF  FF  ."3DUfw.........

Issues/PRs references

@fabian18 fabian18 added the Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer label Dec 13, 2023
@github-actions github-actions bot added the Area: tests Area: tests and testing framework label Dec 13, 2023
@fabian18 fabian18 force-pushed the pr/test_periph_flashpage_raw branch from 9dcd680 to d24449d Compare March 27, 2024 09:12
Teufelchen1
Teufelchen1 approved these changes Mar 27, 2024
View reviewed changes
Copy link
Contributor

@Teufelchen1 Teufelchen1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Teufelchen1 Teufelchen1 added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Mar 27, 2024
@riot-ci
Copy link

riot-ci commented Mar 27, 2024 •
edited
Loading

Murdock results

✔️ PASSED

629c0c2 tests/periph/flashpage: make mtd_raw write bytes instead of ASCII

Success Failures Total Runtime
38 0 39 01m:29s

Artifacts

@fabian18 fabian18 force-pushed the pr/test_periph_flashpage_raw branch from d24449d to 5eb2fc3 Compare March 27, 2024 11:03
@Teufelchen1 Teufelchen1 added this pull request to the merge queue Mar 27, 2024
@benpicco benpicco removed this pull request from the merge queue due to a manual request Mar 27, 2024
@fabian18 fabian18 force-pushed the pr/test_periph_flashpage_raw branch from 5eb2fc3 to 629c0c2 Compare May 6, 2024 15:50
@Teufelchen1
Copy link
Contributor

Whats the change from the last force push? Can I press merge?

@fabian18 fabian18 added this pull request to the merge queue Jun 10, 2024
Merged via the queue into RIOT-OS:master with commit 772ccb9 Jun 10, 2024
26 checks passed
@mguetschow mguetschow added this to the Release 2024.07 milestone Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Teufelchen1 Teufelchen1 Teufelchen1 approved these changes

@smlng smlng Awaiting requested review from smlng

@leandrolanzieri leandrolanzieri Awaiting requested review from leandrolanzieri leandrolanzieri is a code owner

@aabadie aabadie Awaiting requested review from aabadie aabadie is a code owner

@MichelRottleuthner MichelRottleuthner Awaiting requested review from MichelRottleuthner MichelRottleuthner is a code owner

@fjmolinas fjmolinas Awaiting requested review from fjmolinas

Assignees
No one assigned
Labels
Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer
Projects
None yet
Milestone
Release 2024.07
Development

Successfully merging this pull request may close these issues.
4 participants
@fabian18 @riot-ci @Teufelchen1 @mguetschow