boards/wemos-zero: fix flashing and doc #20179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix flashing with `MOST_RECENT_PORT=1` by detecting the board when either in RIOT mode or in bootloader mode (which matches different USB vendor and model strings). Support for programming with the nrf52-u2f bootloader was dropped apparently, but the documentation still recommends that over the Arduino Bootloader. This brings doc and code in sync.
maribu
added
Type: bug
benpicco
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
Fix flashing with
MOST_RECENT_PORT=1by detecting the board when either in RIOT mode or in bootloader mode (which matches different USB vendor and model strings).Support for programming with the nrf52-u2f bootloader was dropped apparently, but the documentation still recommends that over the Arduino Bootloader. This brings doc and code in sync.
Testing procedure
should now succeed, even after double-pressing the reset button.
Issues/PRs references
None