pkg/flashdb: enhance FAL config

[fabian18]

Contribution description

I wanted to split out the FlashDB fal_cfg partition offset fix from #19557.
This also adds a short test to see if all partitions initialize fine and it adds a configuration option for the sector size.
The test very much reminds of an auto_init module for FLashDB.

Testing procedure

Test output of BOARD=same54-xpro make -C tests/pkg/flashdb_fal_cfg flash term

2024-01-03 00:09:14,858 # main(): This is RIOT! (Version: 2024.01-devel-475-g2de30-pr/flashdb_cfg_enhancement)
2024-01-03 00:09:14,862 # Initializing FlashDB KVDB partition part0
2024-01-03 00:09:14,869 # [I/FAL] Flash Abstraction Layer (V0.5.99) initialize success.
2024-01-03 00:09:14,879 # Initializing FlashDB KVDB partition part1
2024-01-03 00:09:14,883 # Initializing FlashDB TSDB partition part2
2024-01-03 00:09:14,887 # Initializing FlashDB TSDB partition part3
2024-01-03 00:09:14,887 # SUCCESS

Issues/PRs references

[benpicco]

This won't work unfortunately.
You don't have the FEATURES_PROVIDED information at this point, so you will always select periph_rtt

[MrKevinWeiss]

This is the known issue with the make dependency resolution... Maybe DEFAULT_MODULE can somehow be used but that only gets resolved on the last iteration.

[fabian18]

I did not figure out how to resolve this with DEFAULT_MODULE but FEATURES_REQUIRED_ANY seems to do a good job here.

When I compile with BOARD=same54-xpro make it compiles fine.
And when I remove FEATURES_PROVIDED += periph_rtc from boards/same54-xpro/Makefile.featuresit also compiles fine with "Using real-time-timer RTC".

[riot-ci]

Murdock results

✔️ PASSED

bf4bfdf tests/pkg/flashdb_fal_cfg: add Makefile.ci

Success	Failures	Total	Runtime
10011	0	10011	10m:33s

Artifacts

• Documentation preview

[benpicco]

Does this work? I would expect that doing this after the dependency resolution won't have any effect.

[fabian18]

I don´t know the magic behind it but I assume it works. When I remove FEATURES_PROVIDED += periph_rtc from boards/same54-xpro/Makefile.features and do an info-modules I see that rtt_rtc and ztimer_no_periph_rtt are in. When I try to build after I remove USEMODULE += rtt_rtc linking fails, as expected.

[fabian18]

tests/pkg/flashdb_fal_cfg/main.c:99: undefined reference to 'rtc_get_time'

[benpicco]

Please squash

[benpicco]

Looks like this output messes up CI

The specified board Using does not exist.

[fabian18]

I was not able to figure this out by the CI message.

[fabian18]

I should say that this is just the default but it can be different for 2 databases.
For that I would rename this to CONFIG_FLASHDB_DEFAULT_MIN_SECTOR_SIZE_EXP.

A module M that initializes a database should have something like:

#ifndef M_FLASHDB_MIN_SECTOR_SIZE_EXP
#define M_FLASHDB_MIN_SECTOR_SIZE_EXP CONFIG_FLASHDB_MIN_SECTOR_SIZE_EXP
#endif

Do you agree?

Hmm and the fact that it can be 10K or 12 actually means that it is not necessarily a power of 2.
I would change it to a factor x KiB Default would be 4 for 4K

[benpicco]

the fact that it can be 10K or 12

Ah ok so there are no assumptions about this being a power of two in the code then - where did you find the 10k sector?

[fabian18]

In the documentation of now CONFIG_FLASHDB_MIN_SECTOR_SIZE_DEFAULT_FACTOR I copied something from the documentation of flashDB Sector size and block size.

[benpicco]

Suggested change

	* @brief Virtual sector size factor in multiples of 1KiB for FlashDB
	* @brief Minimal virtual sector size in KiB for FlashDB

[benpicco]

Suggested change

	#define CONFIG_FLASHDB_MIN_SECTOR_SIZE_DEFAULT_FACTOR 4
	#define CONFIG_FLASHDB_MIN_SECTOR_SIZE_DEFAULT_KiB 4

Instead of FACTOR you can just use the unit.

The MIN DEFAULT is a bit confusion, maybe add a note that this is only for the automatic partition configuration.

[benpicco]

You might have to run make generate-Makefile.ci