Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nanocoap_sock: implement separate response #20266

Merged
merged 9 commits into from
May 21, 2024
Merged

nanocoap_sock: implement separate response #20266

merged 9 commits into from
May 21, 2024

Conversation

benpicco
Copy link
Contributor

Contribution description

This adds the capability to nanocoap_server to send separate response, that is a delayed response outside the CoAP handler.
The CoAP handler will first send an empty ACK (if the request was conformable), then some other function can send the actual response at a later time, using nanocoap_sock_send_separate() with the request context information serialized into nanocoap_sock_response_ctx_t.

Testing procedure

A /separate endpoint was added to examples/nanocoap_server:

$ aiocoap-client coap://[fe80::748f:e6ff:fed7:426d%tapbr0]/separate
This is a delayed response.

2024-01-16 19:47:29,617 # main(): This is RIOT! (Version: 2024.01-devel-601-gbd62d-nanocoap_reply_separate)
2024-01-16 19:47:29,618 # RIOT nanocoap example application
2024-01-16 19:47:29,618 # Waiting for address autoconfiguration...
2024-01-16 19:47:31,616 # {"IPv6 addresses": ["fe80::748f:e6ff:fed7:426d"]}
2024-01-16 19:47:33,248 # _separate_handler(): send ACK, schedule response
2024-01-16 19:47:34,248 # _separate_handler(): send delayed response

Issues/PRs references

@github-actions github-actions bot added Area: network Area: Networking Area: CoAP Area: Constrained Application Protocol implementations Area: sys Area: System Area: examples Area: Example Applications labels Jan 16, 2024
@benpicco benpicco requested review from chrysn and maribu January 16, 2024 18:48
@benpicco benpicco force-pushed the nanocoap_reply_separate branch from bd62dee to 6c5df43 Compare January 16, 2024 21:41
@benpicco benpicco added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jan 16, 2024
@riot-ci
Copy link

riot-ci commented Jan 16, 2024 •
edited
Loading

Murdock results

✔️ PASSED

63d5a5a examples/nanocoap_server: add endpoint with separate response

Success Failures Total Runtime
10105 0 10105 13m:03s

Artifacts

@benpicco benpicco added the Type: new feature The issue requests / The PR implemements a new feature for RIOT label Jan 18, 2024
@benpicco benpicco requested a review from mguetschow January 19, 2024 12:41
@benpicco benpicco mentioned this pull request Jan 23, 2024
Merged
@benpicco benpicco force-pushed the nanocoap_reply_separate branch from 6c5df43 to 91513e0 Compare February 3, 2024 17:38
@benpicco benpicco requested a review from fabian18 March 7, 2024 13:09
fabian18
fabian18 reviewed Apr 19, 2024
View reviewed changes
sys/net/application_layer/nanocoap/nanocoap.c Outdated Show resolved Hide resolved
sys/include/net/nanocoap_sock.h Outdated Show resolved Hide resolved
sys/include/net/nanocoap.h Show resolved Hide resolved
sys/include/net/nanocoap_sock.h Outdated Show resolved Hide resolved
examples/nanocoap_server/coap_handler.c Show resolved Hide resolved
examples/nanocoap_server/coap_handler.c Outdated Show resolved Hide resolved
sys/net/application_layer/nanocoap/sock.c Show resolved Hide resolved
fabian18
fabian18 reviewed Apr 24, 2024
View reviewed changes
sys/include/net/nanocoap.h Show resolved Hide resolved
sys/net/application_layer/nanocoap/sock.c Outdated Show resolved Hide resolved
sys/net/application_layer/nanocoap/nanocoap.c Show resolved Hide resolved
examples/nanocoap_server/Makefile Outdated Show resolved Hide resolved
fabian18
fabian18 reviewed Apr 27, 2024
View reviewed changes
sys/include/net/nanocoap_sock.h Outdated Show resolved Hide resolved
sys/include/net/nanocoap_sock.h Outdated Show resolved Hide resolved
sys/net/application_layer/nanocoap/sock.c Outdated Show resolved Hide resolved
sys/net/application_layer/nanocoap/nanocoap.c Outdated Show resolved Hide resolved
fabian18
fabian18 approved these changes May 21, 2024
View reviewed changes
Copy link
Contributor

@fabian18 fabian18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may squash. ACK

@benpicco benpicco force-pushed the nanocoap_reply_separate branch from de8292e to 63d5a5a Compare May 21, 2024 17:28
@benpicco benpicco added this pull request to the merge queue May 21, 2024
Merged via the queue into RIOT-OS:master with commit 3f41494 May 21, 2024
25 checks passed
@benpicco benpicco deleted the nanocoap_reply_separate branch May 21, 2024 21:37
@mguetschow mguetschow added this to the Release 2024.07 milestone Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabian18 fabian18 fabian18 approved these changes

@miri64 miri64 Awaiting requested review from miri64 miri64 is a code owner

@PeterKietzmann PeterKietzmann Awaiting requested review from PeterKietzmann PeterKietzmann is a code owner

@chrysn chrysn Awaiting requested review from chrysn

@maribu maribu Awaiting requested review from maribu

@mguetschow mguetschow Awaiting requested review from mguetschow

@kaspar030 kaspar030 Awaiting requested review from kaspar030

@bergzand bergzand Awaiting requested review from bergzand

Assignees
No one assigned
Labels
Area: CoAP Area: Constrained Application Protocol implementations Area: examples Area: Example Applications Area: network Area: Networking Area: sys Area: System CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: new feature The issue requests / The PR implemements a new feature for RIOT
Projects
None yet
Milestone
Release 2024.07
Development

Successfully merging this pull request may close these issues.
4 participants
@benpicco @riot-ci @fabian18 @mguetschow