-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pkg/emlearn: bump version to 0.17.1 #20347
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aabadie
requested review from
leandrolanzieri and
MichelRottleuthner
as code owners
February 7, 2024 08:07
github-actions
bot
added
Area: tests
Area: tests and testing framework
Area: pkg
Area: External package ports
labels
Feb 7, 2024
aabadie
added
the
CI: ready for build
If set, CI server will compile all applications for all available boards for the labeled PR
label
Feb 7, 2024
benpicco
added
the
State: waiting for CI update
State: The PR requires an Update to CI to be performed first
label
Feb 12, 2024
benpicco
removed
the
State: waiting for CI update
State: The PR requires an Update to CI to be performed first
label
Aug 28, 2024
maribu
added
CI: ready for build
If set, CI server will compile all applications for all available boards for the labeled PR
and removed
CI: ready for build
If set, CI server will compile all applications for all available boards for the labeled PR
labels
Aug 28, 2024
aabadie
added
CI: ready for build
If set, CI server will compile all applications for all available boards for the labeled PR
and removed
CI: ready for build
If set, CI server will compile all applications for all available boards for the labeled PR
labels
Aug 29, 2024
benpicco
added
CI: ready for build
If set, CI server will compile all applications for all available boards for the labeled PR
and removed
CI: ready for build
If set, CI server will compile all applications for all available boards for the labeled PR
labels
Sep 26, 2024
benpicco
approved these changes
Sep 26, 2024
Thanks! |
Backport provided in #20929 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Area: pkg
Area: External package ports
Area: tests
Area: tests and testing framework
CI: ready for build
If set, CI server will compile all applications for all available boards for the labeled PR
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR is probably not enough because the new trained model is stored using joblib 1.3 and is not compatible with the joblib version available in the riotdocker image. But an update of joblib (and scikit-learn) in riotdocker should work.
Testing procedure
make -C tests/pkg/emlearn all test
works:Issues/PRs references