Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/emlearn: bump version to 0.17.1 #20347

Merged
merged 2 commits into from
Sep 26, 2024

Conversation

aabadie
Copy link
Contributor

@aabadie aabadie commented Feb 7, 2024

Contribution description

This PR is probably not enough because the new trained model is stored using joblib 1.3 and is not compatible with the joblib version available in the riotdocker image. But an update of joblib (and scikit-learn) in riotdocker should work.

Testing procedure

  • Green CI
  • make -C tests/pkg/emlearn all test works:
make -C tests/pkg/emlearn/ all test
make: Entering directory '/work/riot/RIOT/tests/pkg/emlearn'
Building application "tests_emlearn" for "native" with MCU "native".

"make" -C /work/riot/RIOT/pkg/emlearn/ 
"make" -C /work/riot/RIOT/boards/common/init
"make" -C /work/riot/RIOT/boards/native
"make" -C /work/riot/RIOT/boards/native/drivers
"make" -C /work/riot/RIOT/core
"make" -C /work/riot/RIOT/core/lib
"make" -C /work/riot/RIOT/cpu/native
"make" -C /work/riot/RIOT/cpu/native/periph
"make" -C /work/riot/RIOT/cpu/native/stdio_native
"make" -C /work/riot/RIOT/drivers
"make" -C /work/riot/RIOT/drivers/periph_common
"make" -C /work/riot/RIOT/sys
"make" -C /work/riot/RIOT/sys/auto_init
"make" -C /work/riot/RIOT/sys/libc
"make" -C /work/riot/RIOT/sys/preprocessor
"make" -C /work/riot/RIOT/sys/test_utils/interactive_sync
"make" -C /work/riot/RIOT/sys/test_utils/print_stack_usage
/usr/bin/ld: warning: /work/riot/RIOT/tests/pkg/emlearn/bin/native/tests_emlearn.elf has a LOAD segment with RWX permissions
   text	   data	    bss	    dec	    hex	filename
  74185	    556	  47836	 122577	  1ded1	/work/riot/RIOT/tests/pkg/emlearn/bin/native/tests_emlearn.elf
r
/work/riot/RIOT/tests/pkg/emlearn/bin/native/tests_emlearn.elf  tap0 
RIOT native interrupts/signals initialized.
RIOT native board initialized.
RIOT native hardware initialization complete.

Help: Press s to start test, r to print it is ready
READY
s
START
main(): This is RIOT! (Version: 2024.04-devel-153-g4efd1d-pkg/emlearn/bump_version)
Predicted digit: 6
{ "threads": [{ "name": "idle", "stack_size": 8192, "stack_used": 436 }]}
{ "threads": [{ "name": "main", "stack_size": 12288, "stack_used": 2248 }]}

make: Leaving directory '/work/riot/RIOT/tests/pkg/emlearn'

Issues/PRs references

@github-actions github-actions bot added Area: tests Area: tests and testing framework Area: pkg Area: External package ports labels Feb 7, 2024
@aabadie aabadie added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Feb 7, 2024
@riot-ci
Copy link

riot-ci commented Feb 7, 2024

Murdock results

✔️ PASSED

4efd1d9 pkg/emlearn: bump to 0.17.1

Success Failures Total Runtime
1 0 1 01m:26s

Artifacts

@benpicco benpicco added the State: waiting for CI update State: The PR requires an Update to CI to be performed first label Feb 12, 2024
@benpicco benpicco removed the State: waiting for CI update State: The PR requires an Update to CI to be performed first label Aug 28, 2024
@maribu maribu added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Aug 28, 2024
@aabadie aabadie added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Aug 29, 2024
@benpicco benpicco added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Sep 26, 2024
@benpicco benpicco enabled auto-merge September 26, 2024 15:14
@benpicco benpicco added this pull request to the merge queue Sep 26, 2024
Merged via the queue into RIOT-OS:master with commit 9d0a2c1 Sep 26, 2024
34 of 35 checks passed
@aabadie aabadie deleted the pkg/emlearn/bump_version branch September 26, 2024 16:00
@aabadie
Copy link
Contributor Author

aabadie commented Sep 26, 2024

Thanks!

@maribu
Copy link
Member

maribu commented Oct 21, 2024

Backport provided in #20929

@benpicco benpicco added this to the Release 2024.10 milestone Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: pkg Area: External package ports Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants